Update handling of ambiguous name references

Update handling of ambiguous name references

Update VM to latest spec. Referencing a name that is imported
from more than one library is no longer a compile-time error.
If one of the sources of an ambiguous reference is a dart library,
the dart library declaration is automatically hidden.

Also fixes a bug where looking up a getter name in a library
found the getter even though the name is filtered out in the
'hide' combinator.

Long-term we should fix the need for repeatedly convert between
the mangled getter and setter names and the untangled name.

Fixes 12915, 12913, 12724.

R=regis@google.com

Committed: https://code.google.com/p/dart/source/detail?r=27312

[hausner, 2013-09-09 18:24:22]

It's not as scary as it looks :)

[regis, 2013-09-09 21:29:07]

LGTM

https://codereview.chromium.org/23484020/diff/1/runtime/vm/class_finalizer.cc
File runtime/vm/class_finalizer.cc (right):

https://codereview.chromium.org/23484020/diff/1/runtime/vm/class_finalizer.cc...
runtime/vm/class_finalizer.cc:258: Error* ambiguity_error) {
Remove this unused parameter ambiguity_error.

https://codereview.chromium.org/23484020/diff/1/runtime/vm/code_descriptors_t...
File runtime/vm/code_descriptors_test.cc (right):

https://codereview.chromium.org/23484020/diff/1/runtime/vm/code_descriptors_t...
runtime/vm/code_descriptors_test.cc:228: EXPECT(!cls.IsNull());  // No ambiguity
error expected.
The comment is a bit cryptic now.

https://codereview.chromium.org/23484020/diff/1/runtime/vm/code_generator_tes...
File runtime/vm/code_generator_test.cc (right):

https://codereview.chromium.org/23484020/diff/1/runtime/vm/code_generator_tes...
runtime/vm/code_generator_test.cc:565: EXPECT_EQ(cls.raw(), result.clazz());  //
No ambiguity error expected.
ditto

https://codereview.chromium.org/23484020/diff/1/runtime/vm/compiler_test.cc
File runtime/vm/compiler_test.cc (right):

https://codereview.chromium.org/23484020/diff/1/runtime/vm/compiler_test.cc#n...
runtime/vm/compiler_test.cc:48: EXPECT(!cls.IsNull());  // No ambiguity error
expected.
ditto

https://codereview.chromium.org/23484020/diff/1/runtime/vm/mirrors_api_impl.cc
File runtime/vm/mirrors_api_impl.cc (right):

https://codereview.chromium.org/23484020/diff/1/runtime/vm/mirrors_api_impl.c...
runtime/vm/mirrors_api_impl.cc:171: if (func.IsNull() && 
HasExternalSetterSuffix(func_name)) {
extra space

https://codereview.chromium.org/23484020/diff/1/runtime/vm/parser.cc
File runtime/vm/parser.cc (right):

https://codereview.chromium.org/23484020/diff/1/runtime/vm/parser.cc#newcode1703
runtime/vm/parser.cc:1703: return core_lib.LookupClass(name);  // No ambiguity
error expected.
Remove comment.

https://codereview.chromium.org/23484020/diff/1/runtime/vm/parser.cc#newcode8464
runtime/vm/parser.cc:8464: unresolved_class_name);
same line?

https://codereview.chromium.org/23484020/diff/1/runtime/vm/parser_test.cc
File runtime/vm/parser_test.cc (right):

https://codereview.chromium.org/23484020/diff/1/runtime/vm/parser_test.cc#new...
runtime/vm/parser_test.cc:20: EXPECT(!cls.IsNull());  // No ambiguity error
expected.
remove comment

https://codereview.chromium.org/23484020/diff/1/runtime/vm/parser_test.cc#new...
runtime/vm/parser_test.cc:54: EXPECT(!cls.IsNull());  // No ambiguity error
expected.
ditto

https://codereview.chromium.org/23484020/diff/1/runtime/vm/parser_test.cc#new...
runtime/vm/parser_test.cc:89: EXPECT(!cls.IsNull());  // No ambiguity error
expected.
ditto

https://codereview.chromium.org/23484020/diff/1/runtime/vm/snapshot.cc
File runtime/vm/snapshot.cc (right):

https://codereview.chromium.org/23484020/diff/1/runtime/vm/snapshot.cc#newcod...
runtime/vm/snapshot.cc:209: cls = library_.LookupClass(str_);  // No ambiguity
error expected.
remove comment

https://codereview.chromium.org/23484020/diff/1/tests/co19/co19-runtime.status
File tests/co19/co19-runtime.status (right):

https://codereview.chromium.org/23484020/diff/1/tests/co19/co19-runtime.statu...
tests/co19/co19-runtime.status:150:
###Language/14_Libraries_and_Scripts/1_Imports_A03_t70: fail # Dart issue 12915
remove these

[hausner, 2013-09-09 21:52:08]

Thank you.

https://codereview.chromium.org/23484020/diff/1/runtime/vm/class_finalizer.cc
File runtime/vm/class_finalizer.cc (right):

https://codereview.chromium.org/23484020/diff/1/runtime/vm/class_finalizer.cc...
runtime/vm/class_finalizer.cc:258: Error* ambiguity_error) {
On 2013/09/09 21:29:07, regis wrote:
> Remove this unused parameter ambiguity_error.

Done.

https://codereview.chromium.org/23484020/diff/1/runtime/vm/code_descriptors_t...
File runtime/vm/code_descriptors_test.cc (right):

https://codereview.chromium.org/23484020/diff/1/runtime/vm/code_descriptors_t...
runtime/vm/code_descriptors_test.cc:228: EXPECT(!cls.IsNull());  // No ambiguity
error expected.
On 2013/09/09 21:29:07, regis wrote:
> The comment is a bit cryptic now.

Done.

https://codereview.chromium.org/23484020/diff/1/runtime/vm/code_generator_tes...
File runtime/vm/code_generator_test.cc (right):

https://codereview.chromium.org/23484020/diff/1/runtime/vm/code_generator_tes...
runtime/vm/code_generator_test.cc:565: EXPECT_EQ(cls.raw(), result.clazz());  //
No ambiguity error expected.
On 2013/09/09 21:29:07, regis wrote:
> ditto

Done.

https://codereview.chromium.org/23484020/diff/1/runtime/vm/compiler_test.cc
File runtime/vm/compiler_test.cc (right):

https://codereview.chromium.org/23484020/diff/1/runtime/vm/compiler_test.cc#n...
runtime/vm/compiler_test.cc:48: EXPECT(!cls.IsNull());  // No ambiguity error
expected.
On 2013/09/09 21:29:07, regis wrote:
> ditto

Done.

https://codereview.chromium.org/23484020/diff/1/runtime/vm/mirrors_api_impl.cc
File runtime/vm/mirrors_api_impl.cc (right):

https://codereview.chromium.org/23484020/diff/1/runtime/vm/mirrors_api_impl.c...
runtime/vm/mirrors_api_impl.cc:171: if (func.IsNull() && 
HasExternalSetterSuffix(func_name)) {
Removed 

On 2013/09/09 21:29:07, regis wrote:
> extra space

https://codereview.chromium.org/23484020/diff/1/runtime/vm/parser.cc
File runtime/vm/parser.cc (right):

https://codereview.chromium.org/23484020/diff/1/runtime/vm/parser.cc#newcode1703
runtime/vm/parser.cc:1703: return core_lib.LookupClass(name);  // No ambiguity
error expected.
On 2013/09/09 21:29:07, regis wrote:
> Remove comment.

Done.

https://codereview.chromium.org/23484020/diff/1/runtime/vm/parser.cc#newcode8464
runtime/vm/parser.cc:8464: unresolved_class_name);
On 2013/09/09 21:29:07, regis wrote:
> same line?

Done.

https://codereview.chromium.org/23484020/diff/1/runtime/vm/parser_test.cc
File runtime/vm/parser_test.cc (right):

https://codereview.chromium.org/23484020/diff/1/runtime/vm/parser_test.cc#new...
runtime/vm/parser_test.cc:20: EXPECT(!cls.IsNull());  // No ambiguity error
expected.
On 2013/09/09 21:29:07, regis wrote:
> remove comment

Done.

https://codereview.chromium.org/23484020/diff/1/runtime/vm/parser_test.cc#new...
runtime/vm/parser_test.cc:54: EXPECT(!cls.IsNull());  // No ambiguity error
expected.
On 2013/09/09 21:29:07, regis wrote:
> ditto

Done.

https://codereview.chromium.org/23484020/diff/1/runtime/vm/parser_test.cc#new...
runtime/vm/parser_test.cc:54: EXPECT(!cls.IsNull());  // No ambiguity error
expected.
On 2013/09/09 21:29:07, regis wrote:
> ditto

Done.

https://codereview.chromium.org/23484020/diff/1/runtime/vm/parser_test.cc#new...
runtime/vm/parser_test.cc:89: EXPECT(!cls.IsNull());  // No ambiguity error
expected.
On 2013/09/09 21:29:07, regis wrote:
> ditto

Done.

https://codereview.chromium.org/23484020/diff/1/runtime/vm/parser_test.cc#new...
runtime/vm/parser_test.cc:89: EXPECT(!cls.IsNull());  // No ambiguity error
expected.
On 2013/09/09 21:29:07, regis wrote:
> ditto

Done.

https://codereview.chromium.org/23484020/diff/1/runtime/vm/snapshot.cc
File runtime/vm/snapshot.cc (right):

https://codereview.chromium.org/23484020/diff/1/runtime/vm/snapshot.cc#newcod...
runtime/vm/snapshot.cc:209: cls = library_.LookupClass(str_);  // No ambiguity
error expected.
On 2013/09/09 21:29:07, regis wrote:
> remove comment

Done.

https://codereview.chromium.org/23484020/diff/1/tests/co19/co19-runtime.status
File tests/co19/co19-runtime.status (right):

https://codereview.chromium.org/23484020/diff/1/tests/co19/co19-runtime.statu...
tests/co19/co19-runtime.status:150:
###Language/14_Libraries_and_Scripts/1_Imports_A03_t70: fail # Dart issue 12915
On 2013/09/09 21:29:07, regis wrote:
> remove these
Oops. Done.

[hausner, 2013-09-09 21:52:56]

Committed patchset #2 manually as r27312 (presubmit successful).