runtime/vm/debugger.cc - Issue 23484020: Update handling of ambiguous name references

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/debugger.cc

Issue 23484020: Update handling of ambiguous name references (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/debugger.cc

===================================================================

--- runtime/vm/debugger.cc (revision 27310)

+++ runtime/vm/debugger.cc (working copy)

@@ -829,9 +829,7 @@

const Library& library,

const String& fname) {

ASSERT(!library.IsNull());

- String& ambiguity_error_msg = String::Handle();

- const Object& object = Object::Handle(

- library.LookupObject(fname, &ambiguity_error_msg));

+ const Object& object = Object::Handle(library.LookupObject(fname));

if (!object.IsNull() && object.IsFunction()) {

return Function::Cast(object).raw();

}

@@ -862,9 +860,7 @@

if (class_name.Length() == 0) {

return ResolveLibraryFunction(library, function_name);

}

- String& ambiguity_error_msg = String::Handle();

- const Class& cls = Class::Handle(

- library.LookupClass(class_name, &ambiguity_error_msg));

+ const Class& cls = Class::Handle(library.LookupClass(class_name));

Function& function = Function::Handle();

if (!cls.IsNull()) {

function = cls.LookupStaticFunction(function_name);

« no previous file with comments | « runtime/vm/dart_entry_test.cc ('k') | runtime/vm/exceptions.cc » ('j') | no next file with comments »