runtime/vm/object_test.cc - Issue 23484020: Update handling of ambiguous name references

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/object_test.cc

Issue 23484020: Update handling of ambiguous name references (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/object_test.cc

===================================================================

--- runtime/vm/object_test.cc (revision 27310)

+++ runtime/vm/object_test.cc (working copy)

@@ -3252,10 +3252,8 @@

static RawClass* GetClass(const Library& lib, const char* name) {

- String& ambiguity_error_msg = String::Handle();

const Class& cls = Class::Handle(

- lib.LookupClass(String::Handle(Symbols::New(name)),

- &ambiguity_error_msg));

+ lib.LookupClass(String::Handle(Symbols::New(name))));

EXPECT(!cls.IsNull()); // No ambiguity error expected.

return cls.raw();

}

@@ -3396,9 +3394,9 @@

EXPECT(!lib.IsNull());

const Class& class_a = Class::Handle(

- lib.LookupClass(String::Handle(Symbols::New("A")), NULL));

+ lib.LookupClass(String::Handle(Symbols::New("A"))));

const Class& class_b = Class::Handle(

- lib.LookupClass(String::Handle(Symbols::New("B")), NULL));

+ lib.LookupClass(String::Handle(Symbols::New("B"))));

const Function& a_test1 =

Function::Handle(GetStaticFunction(class_a, "test1"));

const Function& b_test1 =

« no previous file with comments | « runtime/vm/object.cc ('k') | runtime/vm/parser.h » ('j') | no next file with comments »