Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Unified Diff: runtime/vm/code_generator_test.cc

Issue 23484020: Update handling of ambiguous name references (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/code_descriptors_test.cc ('k') | runtime/vm/compiler_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/code_generator_test.cc
===================================================================
--- runtime/vm/code_generator_test.cc (revision 27310)
+++ runtime/vm/code_generator_test.cc (working copy)
@@ -275,8 +275,7 @@
static RawClass* LookupClass(const Library& lib, const char* name) {
const String& cls_name = String::ZoneHandle(Symbols::New(name));
- String& ambiguity_error_msg = String::Handle();
- return lib.LookupClass(cls_name, &ambiguity_error_msg);
+ return lib.LookupClass(cls_name);
}
@@ -296,7 +295,7 @@
EXPECT(CompilerTest::TestCompileScript(lib, script));
EXPECT(ClassFinalizer::FinalizePendingClasses());
Class& cls = Class::Handle(LookupClass(lib, "A"));
- EXPECT(!cls.IsNull()); // No ambiguity error expected.
+ EXPECT(!cls.IsNull());
// 'bar' will not be compiled.
String& function_bar_name = String::Handle(String::New("bar"));
@@ -343,7 +342,7 @@
EXPECT(CompilerTest::TestCompileScript(lib, script));
EXPECT(ClassFinalizer::FinalizePendingClasses());
Class& cls = Class::ZoneHandle(LookupClass(lib, "A"));
- EXPECT(!cls.IsNull()); // No ambiguity error expected.
+ EXPECT(!cls.IsNull());
String& constructor_name = String::Handle(String::New("A."));
Function& constructor =
@@ -535,7 +534,7 @@
EXPECT(CompilerTest::TestCompileScript(lib, script));
EXPECT(ClassFinalizer::FinalizePendingClasses());
Class& cls = Class::ZoneHandle(LookupClass(lib, "A"));
- EXPECT(!cls.IsNull()); // No ambiguity error expected.
+ EXPECT(!cls.IsNull());
String& constructor_name = String::Handle(String::New("A."));
Function& constructor =
@@ -561,11 +560,9 @@
Library& app_lib = Library::Handle();
app_lib ^= libs.At(num_libs - 1);
ASSERT(!app_lib.IsNull());
- String& ambiguity_error_msg = String::Handle();
const Class& cls = Class::Handle(
- app_lib.LookupClass(String::Handle(Symbols::New("A")),
- &ambiguity_error_msg));
- EXPECT_EQ(cls.raw(), result.clazz()); // No ambiguity error expected.
+ app_lib.LookupClass(String::Handle(Symbols::New("A"))));
+ EXPECT_EQ(cls.raw(), result.clazz());
}
} // namespace dart
« no previous file with comments | « runtime/vm/code_descriptors_test.cc ('k') | runtime/vm/compiler_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698