Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Issue 19564014: Add all 256 shuffle methods to Float32x4 (Closed)

Created:
7 years, 5 months ago by Cutch
Modified:
7 years, 5 months ago
Reviewers:
srdjan, siva
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add all 256 shuffle methods to Float32x4 R=srdjan@google.com Committed: https://code.google.com/p/dart/source/detail?r=25227

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2162 lines, -84 lines) Patch
M runtime/lib/simd128.cc View 1 2 3 1 chunk +9 lines, -24 lines 0 comments Download
M runtime/lib/typed_data.dart View 1 2 3 1 chunk +257 lines, -4 lines 1 comment Download
M runtime/vm/bootstrap_natives.h View 1 2 3 1 chunk +1 line, -4 lines 0 comments Download
M runtime/vm/flow_graph_optimizer.cc View 1 2 3 3 chunks +17 lines, -4 lines 0 comments Download
M runtime/vm/intermediate_language.h View 1 2 3 4 chunks +8 lines, -6 lines 0 comments Download
M runtime/vm/intermediate_language_arm.cc View 1 2 3 2 chunks +14 lines, -12 lines 0 comments Download
M runtime/vm/intermediate_language_ia32.cc View 1 2 3 2 chunks +3 lines, -13 lines 0 comments Download
M runtime/vm/intermediate_language_x64.cc View 1 2 3 2 chunks +3 lines, -12 lines 0 comments Download
M sdk/lib/typed_data/typed_data.dart View 1 chunk +508 lines, -5 lines 0 comments Download
M tests/lib/lib.status View 1 2 3 3 chunks +3 lines, -0 lines 0 comments Download
A tests/lib/typed_data/float32x4_shuffle_test.dart View 1 2 3 1 chunk +1319 lines, -0 lines 0 comments Download
M tests/lib/typed_data/float32x4_test.dart View 1 1 chunk +20 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Cutch
PTAL. It's almost ready to land (I need to implement X64 and add some tests). ...
7 years, 5 months ago (2013-07-19 00:01:58 UTC) #1
Cutch
Patch Set 2 is ready for review for landing.
7 years, 5 months ago (2013-07-19 00:10:56 UTC) #2
zra
On 2013/07/19 00:01:58, Cutch wrote: > PTAL. > > It's almost ready to land (I ...
7 years, 5 months ago (2013-07-19 00:31:25 UTC) #3
srdjan
lgtm
7 years, 5 months ago (2013-07-19 16:39:10 UTC) #4
Cutch
Committed patchset #4 manually as r25227 (presubmit successful).
7 years, 5 months ago (2013-07-19 17:03:17 UTC) #5
siva
7 years, 5 months ago (2013-07-26 01:07:23 UTC) #6
Message was sent while issue was closed.
https://codereview.chromium.org/19564014/diff/8001/runtime/lib/typed_data.dart
File runtime/lib/typed_data.dart (right):

https://codereview.chromium.org/19564014/diff/8001/runtime/lib/typed_data.dar...
runtime/lib/typed_data.dart:2264: Float32x4 get wwww => _shuffle(0xFF);
John,

One quick question instead of having individual getters like
this xxxx, xxxy etc. would it be ok to have one generic getter
that takes a constant as a parameter
e.g:
<somename>(int attribute) and we define constants XXXX, XXXY etc.
so uses would do <somename>(XXXX) instead of xxxx.

Would that be very unreadable in the code?

Powered by Google App Engine
This is Rietveld 408576698