Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Unified Diff: runtime/vm/flow_graph_optimizer.cc

Issue 19564014: Add all 256 shuffle methods to Float32x4 (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/flow_graph_optimizer.cc
diff --git a/runtime/vm/flow_graph_optimizer.cc b/runtime/vm/flow_graph_optimizer.cc
index e3a1f826d379b074ad6e2e4853a0429fa0cd4a0e..69e475fcb792682f78f1e2cbae8f28bac7abede1 100644
--- a/runtime/vm/flow_graph_optimizer.cc
+++ b/runtime/vm/flow_graph_optimizer.cc
@@ -1468,9 +1468,23 @@ bool FlowGraphOptimizer::InlineFloat32x4Getter(InstanceCallInstr* call,
call->deopt_id(),
call->env(),
call);
+ intptr_t mask = 0;
+ if (getter == MethodRecognizer::kFloat32x4Shuffle) {
+ ASSERT(call->ArgumentCount() == 2);
+ // Extract shuffle mask.
+ Definition* mask_definition = call->ArgumentAt(1);
+ ASSERT(mask_definition->IsConstant());
+ ConstantInstr* constant_instruction = mask_definition->AsConstant();
+ const Object& constant_mask = constant_instruction->value();
+ ASSERT(constant_mask.IsSmi());
+ mask = Smi::Cast(constant_mask).Value();
+ ASSERT(mask >= 0);
+ ASSERT(mask <= 255);
+ }
Float32x4ShuffleInstr* instr = new Float32x4ShuffleInstr(
getter,
new Value(call->ArgumentAt(0)),
+ mask,
call->deopt_id());
ReplaceCall(call, instr);
return true;
@@ -1561,10 +1575,6 @@ bool FlowGraphOptimizer::TryInlineInstanceGetter(InstanceCallInstr* call) {
}
InlineStringIsEmptyGetter(call);
return true;
- case MethodRecognizer::kFloat32x4ShuffleXXXX:
- case MethodRecognizer::kFloat32x4ShuffleYYYY:
- case MethodRecognizer::kFloat32x4ShuffleZZZZ:
- case MethodRecognizer::kFloat32x4ShuffleWWWW:
case MethodRecognizer::kFloat32x4ShuffleX:
case MethodRecognizer::kFloat32x4ShuffleY:
case MethodRecognizer::kFloat32x4ShuffleZ:
@@ -2035,6 +2045,9 @@ bool FlowGraphOptimizer::TryInlineFloat32x4Method(
ReplaceCall(call, cast);
return true;
}
+ case MethodRecognizer::kFloat32x4Shuffle: {
+ return InlineFloat32x4Getter(call, recognized_kind);
+ }
default:
return false;
}

Powered by Google App Engine
This is Rietveld 408576698