Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(449)

Unified Diff: runtime/lib/simd128.cc

Issue 19564014: Add all 256 shuffle methods to Float32x4 (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/lib/typed_data.dart » ('j') | runtime/lib/typed_data.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/lib/simd128.cc
diff --git a/runtime/lib/simd128.cc b/runtime/lib/simd128.cc
index 81894feffbc752c1078be648bf08f01cb652b7ba..542eee4896732f56217f1b4588ac985a9c4196dd 100644
--- a/runtime/lib/simd128.cc
+++ b/runtime/lib/simd128.cc
@@ -229,31 +229,16 @@ DEFINE_NATIVE_ENTRY(Float32x4_getW, 1) {
}
-DEFINE_NATIVE_ENTRY(Float32x4_getXXXX, 1) {
+DEFINE_NATIVE_ENTRY(Float32x4_shuffle, 2) {
GET_NON_NULL_NATIVE_ARGUMENT(Float32x4, self, arguments->NativeArgAt(0));
- float value = self.x();
- return Float32x4::New(value, value, value, value);
-}
-
-
-DEFINE_NATIVE_ENTRY(Float32x4_getYYYY, 1) {
- GET_NON_NULL_NATIVE_ARGUMENT(Float32x4, self, arguments->NativeArgAt(0));
- float value = self.y();
- return Float32x4::New(value, value, value, value);
-}
-
-
-DEFINE_NATIVE_ENTRY(Float32x4_getZZZZ, 1) {
- GET_NON_NULL_NATIVE_ARGUMENT(Float32x4, self, arguments->NativeArgAt(0));
- float value = self.z();
- return Float32x4::New(value, value, value, value);
-}
-
-
-DEFINE_NATIVE_ENTRY(Float32x4_getWWWW, 1) {
- GET_NON_NULL_NATIVE_ARGUMENT(Float32x4, self, arguments->NativeArgAt(0));
- float value = self.w();
- return Float32x4::New(value, value, value, value);
+ GET_NON_NULL_NATIVE_ARGUMENT(Integer, mask, arguments->NativeArgAt(1));
+ int64_t m = mask.AsInt64Value();
+ float data[4] = { self.x(), self.y(), self.z(), self.w() };
+ float _x = data[m & 0x3];
+ float _y = data[(m >> 2) & 0x3];
+ float _z = data[(m >> 4) & 0x3];
+ float _w = data[(m >> 6) & 0x3];
+ return Float32x4::New(_x, _y, _z, _w);
}
« no previous file with comments | « no previous file | runtime/lib/typed_data.dart » ('j') | runtime/lib/typed_data.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698