Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1541)

Unified Diff: runtime/vm/intermediate_language_arm.cc

Issue 19564014: Add all 256 shuffle methods to Float32x4 (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/intermediate_language_arm.cc
diff --git a/runtime/vm/intermediate_language_arm.cc b/runtime/vm/intermediate_language_arm.cc
index 59b75a36e7b781642022cee3b0b95420299a067a..416e04e073ca67e135543c1c21c8ad46186d2e8b 100644
--- a/runtime/vm/intermediate_language_arm.cc
+++ b/runtime/vm/intermediate_language_arm.cc
@@ -2965,18 +2965,6 @@ void Float32x4ShuffleInstr::EmitNativeCode(FlowGraphCompiler* compiler) {
// For these cases the vdup instruction requires fewer
// instructions. For arbitrary shuffles, vtbl will be needed.
switch (op_kind()) {
- case MethodRecognizer::kFloat32x4ShuffleXXXX:
- __ vdup(kWord, result, dvalue0, 0);
- break;
- case MethodRecognizer::kFloat32x4ShuffleYYYY:
- __ vdup(kWord, result, dvalue0, 1);
- break;
- case MethodRecognizer::kFloat32x4ShuffleZZZZ:
- __ vdup(kWord, result, dvalue1, 0);
- break;
- case MethodRecognizer::kFloat32x4ShuffleWWWW:
- __ vdup(kWord, result, dvalue1, 1);
- break;
case MethodRecognizer::kFloat32x4ShuffleX:
__ vdup(kWord, result, dvalue0, 0);
__ vcvtds(dresult0, sresult0);
@@ -2993,6 +2981,20 @@ void Float32x4ShuffleInstr::EmitNativeCode(FlowGraphCompiler* compiler) {
__ vdup(kWord, result, dvalue1, 1);
__ vcvtds(dresult0, sresult0);
break;
+ case MethodRecognizer::kFloat32x4Shuffle:
+ if (mask_ == 0x00) {
+ __ vdup(kWord, result, dvalue0, 0);
+ } else if (mask_ == 0x55) {
+ __ vdup(kWord, result, dvalue0, 1);
+ } else if (mask_ == 0xAA) {
+ __ vdup(kWord, result, dvalue1, 0);
+ } else if (mask_ == 0xFF) {
+ __ vdup(kWord, result, dvalue1, 1);
+ } else {
+ // TODO(zra): Implement other shuffles.
+ UNIMPLEMENTED();
+ }
+ break;
default: UNREACHABLE();
}
}

Powered by Google App Engine
This is Rietveld 408576698