Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Unified Diff: runtime/vm/intermediate_language_x64.cc

Issue 19564014: Add all 256 shuffle methods to Float32x4 (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/intermediate_language_x64.cc
diff --git a/runtime/vm/intermediate_language_x64.cc b/runtime/vm/intermediate_language_x64.cc
index a320b957704d354e9504655897a1ce23a90e01d0..d0b0245efb5b6c4a59b7bfd62913fbc8a0a6d2e0 100644
--- a/runtime/vm/intermediate_language_x64.cc
+++ b/runtime/vm/intermediate_language_x64.cc
@@ -3047,18 +3047,6 @@ void Float32x4ShuffleInstr::EmitNativeCode(FlowGraphCompiler* compiler) {
ASSERT(locs()->out().fpu_reg() == value);
switch (op_kind()) {
- case MethodRecognizer::kFloat32x4ShuffleXXXX:
- __ shufps(value, value, Immediate(0x00));
- break;
- case MethodRecognizer::kFloat32x4ShuffleYYYY:
- __ shufps(value, value, Immediate(0x55));
- break;
- case MethodRecognizer::kFloat32x4ShuffleZZZZ:
- __ shufps(value, value, Immediate(0xAA));
- break;
- case MethodRecognizer::kFloat32x4ShuffleWWWW:
- __ shufps(value, value, Immediate(0xFF));
- break;
case MethodRecognizer::kFloat32x4ShuffleX:
__ shufps(value, value, Immediate(0x00));
__ cvtss2sd(value, value);
@@ -3075,6 +3063,9 @@ void Float32x4ShuffleInstr::EmitNativeCode(FlowGraphCompiler* compiler) {
__ shufps(value, value, Immediate(0xFF));
__ cvtss2sd(value, value);
break;
+ case MethodRecognizer::kFloat32x4Shuffle:
+ __ shufps(value, value, Immediate(mask_));
+ break;
default: UNREACHABLE();
}
}

Powered by Google App Engine
This is Rietveld 408576698