Improve the instance-view page in observatory.

Improve the instance-view page in observatory.

Add an eval-box element which is used to evaluate expressions.

Support expression evaluation for instances in the vm service.

R=johnmccutchan@google.com

Committed: https://code.google.com/p/dart/source/detail?r=33592

[turnidge, 2014-03-11 20:59:44]

Ok, it's ready now.

[Cutch, 2014-03-11 22:06:45]

lgtm w/ comments.

https://codereview.chromium.org/194623006/diff/40001/runtime/bin/vmservice/cl...
File runtime/bin/vmservice/client/lib/src/elements/eval_box.dart (right):

https://codereview.chromium.org/194623006/diff/40001/runtime/bin/vmservice/cl...
runtime/bin/vmservice/client/lib/src/elements/eval_box.dart:22: @published
ObservableList expressions = toObservable([]);
Should this be marked as @observable instead of @published? We should be strict
about our usage of these attributes:

@published -> you expect this to be set via an HTML attribute. Implies
@observable.
@observable -> you want templates to re-evaluate when this changes. Implies
@reflectable.
@reflectable -> you want dart2js to keep this no matter what.

https://codereview.chromium.org/194623006/diff/40001/runtime/bin/vmservice/cl...
File runtime/bin/vmservice/client/lib/src/service/service.dart (right):

https://codereview.chromium.org/194623006/diff/40001/runtime/bin/vmservice/cl...
runtime/bin/vmservice/client/lib/src/service/service.dart:167:
Logger.root.error("Malformed service object: $m");
I was in the kitchen getting water and thought we should add this. WOOOAAH.

https://codereview.chromium.org/194623006/diff/40001/runtime/vm/service.cc
File runtime/vm/service.cc (right):

https://codereview.chromium.org/194623006/diff/40001/runtime/vm/service.cc#ne...
runtime/vm/service.cc:956: Object::sentinel().PrintToJSONStream(js, false);
I wonder if we can make all of these special objects into our id-less objects
and never have to handle them here. Longer term.

[turnidge, 2014-03-11 22:23:22]

Done.  Also snuck in a fix in eval_box.html that displays multi-line expressions
in a slightly nicer way.

Plan on committing this tomorrow AM.

https://codereview.chromium.org/194623006/diff/40001/runtime/bin/vmservice/cl...
File runtime/bin/vmservice/client/lib/src/elements/eval_box.dart (right):

https://codereview.chromium.org/194623006/diff/40001/runtime/bin/vmservice/cl...
runtime/bin/vmservice/client/lib/src/elements/eval_box.dart:22: @published
ObservableList expressions = toObservable([]);
On 2014/03/11 22:06:46, Cutch wrote:
> Should this be marked as @observable instead of @published? We should be
strict
> about our usage of these attributes:
> 
> @published -> you expect this to be set via an HTML attribute. Implies
> @observable.
> @observable -> you want templates to re-evaluate when this changes. Implies
> @reflectable.
> @reflectable -> you want dart2js to keep this no matter what.

Done.

https://codereview.chromium.org/194623006/diff/40001/runtime/bin/vmservice/cl...
File runtime/bin/vmservice/client/lib/src/service/service.dart (right):

https://codereview.chromium.org/194623006/diff/40001/runtime/bin/vmservice/cl...
runtime/bin/vmservice/client/lib/src/service/service.dart:167:
Logger.root.error("Malformed service object: $m");
On 2014/03/11 22:06:46, Cutch wrote:
> I was in the kitchen getting water and thought we should add this. WOOOAAH.

Indeed.

https://codereview.chromium.org/194623006/diff/40001/runtime/vm/service.cc
File runtime/vm/service.cc (right):

https://codereview.chromium.org/194623006/diff/40001/runtime/vm/service.cc#ne...
runtime/vm/service.cc:956: Object::sentinel().PrintToJSONStream(js, false);
On 2014/03/11 22:06:46, Cutch wrote:
> I wonder if we can make all of these special objects into our id-less objects
> and never have to handle them here. Longer term.

I agree.  So let it be.

[turnidge, 2014-03-12 17:18:30]

Committed patchset #5 manually as r33592 (presubmit successful).