Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Unified Diff: runtime/bin/vmservice/client/lib/src/elements/instance_view.dart

Issue 194623006: Improve the instance-view page in observatory. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: gen js / fix stuff Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/bin/vmservice/client/lib/src/elements/instance_view.dart
diff --git a/runtime/bin/vmservice/client/lib/src/elements/instance_view.dart b/runtime/bin/vmservice/client/lib/src/elements/instance_view.dart
index faec9db8904ea7dfa8dd151685a9fa1d71e7d8ed..5a0f9ba068adef8187758a83d3735a1fe4bda5f4 100644
--- a/runtime/bin/vmservice/client/lib/src/elements/instance_view.dart
+++ b/runtime/bin/vmservice/client/lib/src/elements/instance_view.dart
@@ -8,8 +8,20 @@ import 'observatory_element.dart';
import 'package:observatory/service.dart';
import 'package:polymer/polymer.dart';
+import 'dart:async';
+
@CustomTag('instance-view')
class InstanceViewElement extends ObservatoryElement {
@published ServiceMap instance;
+
InstanceViewElement.created() : super.created();
+
+ Future<ServiceObject> eval(String text) {
+ return instance.isolate.get(
+ instance.id + "/eval?expr=${Uri.encodeComponent(text)}");
+ }
+
+ void refresh(var done) {
+ instance.reload().whenComplete(done);
+ }
}

Powered by Google App Engine
This is Rietveld 408576698