runtime/bin/vmservice/client/lib/src/elements/observatory_element.dart - Issue 194623006: Improve the instance-view page in observatory.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/bin/vmservice/client/lib/src/elements/observatory_element.dart

Issue 194623006: Improve the instance-view page in observatory. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: gen js / fix stuff Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « runtime/bin/vmservice/client/lib/src/elements/instance_view.html ('k') | runtime/bin/vmservice/client/lib/src/service/service.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: runtime/bin/vmservice/client/lib/src/elements/observatory_element.dart

diff --git a/runtime/bin/vmservice/client/lib/src/elements/observatory_element.dart b/runtime/bin/vmservice/client/lib/src/elements/observatory_element.dart

index 210aa01a67c52a3046098871ed3404e0b027b078..76c2347c94e14137434d26073c2f3f56e40f2e03 100644

--- a/runtime/bin/vmservice/client/lib/src/elements/observatory_element.dart

+++ b/runtime/bin/vmservice/client/lib/src/elements/observatory_element.dart

@@ -97,6 +97,10 @@ class ObservatoryElement extends PolymerElement {

bool isNull(String type) {

return type == 'Null';

}

+ bool isError(String type) {

+ return type == 'Error';

+ }

bool isInt(String type) {

return (type == 'Smi' ||

@@ -135,6 +139,7 @@ class ObservatoryElement extends PolymerElement {

'Closure',

'Instance',

'GrowableObjectArray',

- 'Array'].contains(type));

+ 'Array',

+ 'Error'].contains(type));

}