Improve the instance-view page in observatory.

runtime/bin/vmservice/client/lib/src/service/service.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of service;
 
 /// A [ServiceObject] is an object known to the VM service and is tied
 /// to an owning [Isolate].
 abstract class ServiceObject extends Observable {
   Isolate _isolate;
@@ skipping 145 matching lines @@
     } else if (v is ObservableMap) {
       _upgradeObservableMap(v, vm, isolate);
     }
   }
 }
 
 /// Upgrades response ([m]) from [vm] and [isolate] to a [ServiceObject].
 /// This acts like a factory which consumes an ObservableMap and returns
 /// a fully upgraded ServiceObject.
 ServiceObject _upgradeToServiceObject(VM vm, Isolate isolate, ObservableMap m) {
+  if (!ServiceObject.isServiceMap(m)) {
+    Logger.root.error("Malformed service object: $m");

[Cutch, 2014/03/11 22:06:46]

I was in the kitchen getting water and thought we should add this. WOOOAAH.

[turnidge, 2014/03/11 22:23:22]

Indeed.

+  }
   assert(ServiceObject.isServiceMap(m));
   var type = ServiceObject.stripRef(m['type']);
   switch (type) {
     case 'Error':
       return new ServiceError.fromMap(isolate, m);
     case 'IsolateList':
       vm.isolates.update(m);
       return vm.isolates;
     case 'Script':
       return isolate.scripts.putIfAbsent(m);
     case 'Code':
       return isolate.codes.putIfAbsent(m);
     case 'Isolate':
       return vm.isolates.getIsolateFromMap(m);
     case 'Class':
       return isolate.classes.putIfAbsent(m);
   }
   return new ServiceMap.fromMap(isolate, m);
-}
+}