Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(842)

Unified Diff: runtime/bin/vmservice/client/lib/src/service/service.dart

Issue 194623006: Improve the instance-view page in observatory. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: gen js / fix stuff Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/bin/vmservice/client/lib/src/elements/observatory_element.dart ('k') | runtime/vm/object.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/bin/vmservice/client/lib/src/service/service.dart
diff --git a/runtime/bin/vmservice/client/lib/src/service/service.dart b/runtime/bin/vmservice/client/lib/src/service/service.dart
index e2c9aa4e00b3e0699476c479ad709ee88b07273b..8f932e9ff002ac074cc0171a606b5038142968c0 100644
--- a/runtime/bin/vmservice/client/lib/src/service/service.dart
+++ b/runtime/bin/vmservice/client/lib/src/service/service.dart
@@ -163,6 +163,9 @@ void _upgradeObservableList(ObservableList list, VM vm, Isolate isolate) {
/// This acts like a factory which consumes an ObservableMap and returns
/// a fully upgraded ServiceObject.
ServiceObject _upgradeToServiceObject(VM vm, Isolate isolate, ObservableMap m) {
+ if (!ServiceObject.isServiceMap(m)) {
+ Logger.root.severe("Malformed service object: $m");
+ }
assert(ServiceObject.isServiceMap(m));
var type = ServiceObject.stripRef(m['type']);
switch (type) {
@@ -181,4 +184,4 @@ ServiceObject _upgradeToServiceObject(VM vm, Isolate isolate, ObservableMap m) {
return isolate.classes.putIfAbsent(m);
}
return new ServiceMap.fromMap(isolate, m);
-}
+}
« no previous file with comments | « runtime/bin/vmservice/client/lib/src/elements/observatory_element.dart ('k') | runtime/vm/object.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698