Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(464)

Issue 16034002: Use helper methods for running pub. (Closed)

Created:
7 years, 7 months ago by Bob Nystrom
Modified:
7 years, 7 months ago
Reviewers:
nweiz
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Use helper methods for running pub. Committed: https://code.google.com/p/dart/source/detail?r=23182

Patch Set 1 #

Patch Set 2 : Get rid of unnecessary RegExps in tests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+128 lines, -257 lines) Patch
M sdk/lib/_internal/pub/lib/src/command.dart View 1 1 chunk +4 lines, -4 lines 0 comments Download
M sdk/lib/_internal/pub/lib/src/package.dart View 1 2 chunks +16 lines, -14 lines 0 comments Download
M sdk/lib/_internal/pub/lib/src/solver/version_solver.dart View 1 2 chunks +2 lines, -26 lines 0 comments Download
M sdk/lib/_internal/pub/test/deploy/copies_dart_js_next_to_entrypoints_test.dart View 1 chunk +1 line, -2 lines 0 comments Download
M sdk/lib/_internal/pub/test/dev_dependency_test.dart View 3 chunks +3 lines, -6 lines 0 comments Download
M sdk/lib/_internal/pub/test/hosted/fail_gracefully_on_missing_package_test.dart View 1 1 chunk +2 lines, -2 lines 0 comments Download
M sdk/lib/_internal/pub/test/hosted/fail_gracefully_on_url_resolve_test.dart View 1 1 chunk +1 line, -2 lines 0 comments Download
M sdk/lib/_internal/pub/test/hosted/offline_test.dart View 1 2 chunks +4 lines, -3 lines 0 comments Download
M sdk/lib/_internal/pub/test/install/broken_symlink_test.dart View 2 chunks +2 lines, -4 lines 0 comments Download
M sdk/lib/_internal/pub/test/install/git/check_out_and_update_test.dart View 2 chunks +2 lines, -4 lines 0 comments Download
M sdk/lib/_internal/pub/test/install/git/check_out_branch_test.dart View 1 chunk +1 line, -2 lines 0 comments Download
M sdk/lib/_internal/pub/test/install/git/check_out_revision_test.dart View 1 chunk +1 line, -2 lines 0 comments Download
M sdk/lib/_internal/pub/test/install/git/check_out_test.dart View 1 chunk +1 line, -2 lines 0 comments Download
M sdk/lib/_internal/pub/test/install/git/check_out_transitive_test.dart View 1 chunk +1 line, -2 lines 0 comments Download
M sdk/lib/_internal/pub/test/install/git/check_out_twice_test.dart View 2 chunks +2 lines, -4 lines 0 comments Download
M sdk/lib/_internal/pub/test/install/git/check_out_with_trailing_slash_test.dart View 1 chunk +1 line, -2 lines 0 comments Download
M sdk/lib/_internal/pub/test/install/git/dependency_name_match_pubspec_test.dart View 1 1 chunk +3 lines, -7 lines 0 comments Download
M sdk/lib/_internal/pub/test/install/git/different_repo_name_test.dart View 1 chunk +1 line, -2 lines 0 comments Download
M sdk/lib/_internal/pub/test/install/git/lock_version_test.dart View 2 chunks +2 lines, -4 lines 0 comments Download
M sdk/lib/_internal/pub/test/install/git/require_pubspec_name_test.dart View 1 1 chunk +3 lines, -4 lines 0 comments Download
M sdk/lib/_internal/pub/test/install/git/require_pubspec_test.dart View 1 1 chunk +1 line, -4 lines 0 comments Download
M sdk/lib/_internal/pub/test/install/git/stay_locked_if_compatible_test.dart View 2 chunks +2 lines, -4 lines 0 comments Download
M sdk/lib/_internal/pub/test/install/git/unlock_if_incompatible_test.dart View 2 chunks +2 lines, -4 lines 0 comments Download
M sdk/lib/_internal/pub/test/install/hosted/cached_pubspec_test.dart View 2 chunks +2 lines, -4 lines 0 comments Download
M sdk/lib/_internal/pub/test/install/hosted/do_not_update_on_removed_constraints_test.dart View 2 chunks +2 lines, -4 lines 0 comments Download
M sdk/lib/_internal/pub/test/install/hosted/install_test.dart View 1 2 chunks +3 lines, -6 lines 0 comments Download
M sdk/lib/_internal/pub/test/install/hosted/install_transitive_test.dart View 1 chunk +1 line, -2 lines 0 comments Download
M sdk/lib/_internal/pub/test/install/hosted/repair_cache_test.dart View 2 chunks +2 lines, -4 lines 0 comments Download
M sdk/lib/_internal/pub/test/install/hosted/resolve_constraints_test.dart View 1 chunk +1 line, -2 lines 0 comments Download
M sdk/lib/_internal/pub/test/install/hosted/stay_locked_if_compatible_test.dart View 2 chunks +2 lines, -4 lines 0 comments Download
M sdk/lib/_internal/pub/test/install/hosted/stay_locked_if_new_is_satisfied_test.dart View 2 chunks +2 lines, -4 lines 0 comments Download
M sdk/lib/_internal/pub/test/install/hosted/stay_locked_test.dart View 2 chunks +2 lines, -4 lines 0 comments Download
M sdk/lib/_internal/pub/test/install/hosted/unlock_if_incompatible_test.dart View 1 chunk +2 lines, -6 lines 0 comments Download
M sdk/lib/_internal/pub/test/install/hosted/unlock_if_new_is_unsatisfied_test.dart View 2 chunks +2 lines, -4 lines 0 comments Download
M sdk/lib/_internal/pub/test/install/path/absolute_path_test.dart View 1 chunk +1 line, -2 lines 0 comments Download
M sdk/lib/_internal/pub/test/install/path/absolute_symlink_test.dart View 1 chunk +1 line, -2 lines 0 comments Download
M sdk/lib/_internal/pub/test/install/path/no_pubspec_test.dart View 1 1 chunk +1 line, -3 lines 0 comments Download
M sdk/lib/_internal/pub/test/install/path/nonexistent_dir_test.dart View 1 1 chunk +1 line, -10 lines 0 comments Download
M sdk/lib/_internal/pub/test/install/path/path_is_file_test.dart View 1 2 chunks +3 lines, -11 lines 0 comments Download
M sdk/lib/_internal/pub/test/install/path/relative_path_test.dart View 2 chunks +2 lines, -4 lines 0 comments Download
M sdk/lib/_internal/pub/test/install/path/relative_symlink_test.dart View 1 chunk +1 line, -2 lines 0 comments Download
M sdk/lib/_internal/pub/test/install/path/shared_dependency_symlink_test.dart View 1 chunk +1 line, -2 lines 0 comments Download
M sdk/lib/_internal/pub/test/install/path/shared_dependency_test.dart View 3 chunks +3 lines, -6 lines 0 comments Download
M sdk/lib/_internal/pub/test/install/relative_symlink_test.dart View 2 chunks +2 lines, -4 lines 0 comments Download
M sdk/lib/_internal/pub/test/install/switch_source_test.dart View 1 chunk +2 lines, -6 lines 0 comments Download
M sdk/lib/_internal/pub/test/pub_install_and_update_test.dart View 1 3 chunks +6 lines, -5 lines 0 comments Download
M sdk/lib/_internal/pub/test/test_pub.dart View 1 1 chunk +4 lines, -6 lines 0 comments Download
M sdk/lib/_internal/pub/test/unknown_source_test.dart View 1 2 chunks +4 lines, -4 lines 0 comments Download
M sdk/lib/_internal/pub/test/update/git/do_not_update_if_unneeded_test.dart View 2 chunks +2 lines, -4 lines 0 comments Download
M sdk/lib/_internal/pub/test/update/git/update_locked_test.dart View 2 chunks +2 lines, -4 lines 0 comments Download
M sdk/lib/_internal/pub/test/update/git/update_one_locked_test.dart View 2 chunks +2 lines, -4 lines 0 comments Download
M sdk/lib/_internal/pub/test/update/git/update_to_incompatible_pubspec_test.dart View 1 2 chunks +3 lines, -6 lines 0 comments Download
M sdk/lib/_internal/pub/test/update/git/update_to_nonexistent_pubspec_test.dart View 1 2 chunks +2 lines, -6 lines 0 comments Download
M sdk/lib/_internal/pub/test/update/hosted/unlock_dependers_test.dart View 2 chunks +2 lines, -4 lines 0 comments Download
M sdk/lib/_internal/pub/test/update/hosted/unlock_if_necessary_test.dart View 2 chunks +2 lines, -4 lines 0 comments Download
M sdk/lib/_internal/pub/test/update/hosted/update_removed_constraints_test.dart View 2 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Bob Nystrom
Committed patchset #2 manually as r23182 (presubmit successful).
7 years, 7 months ago (2013-05-24 21:15:44 UTC) #1
nweiz
7 years, 7 months ago (2013-05-24 22:32:32 UTC) #2
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698