sdk/lib/_internal/pub/test/install/git/dependency_name_match_pubspec_test.dart - Issue 16034002: Use helper methods for running pub.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/pub/test/install/git/dependency_name_match_pubspec_test.dart

Issue 16034002: Use helper methods for running pub. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Get rid of unnecessary RegExps in tests. Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sdk/lib/_internal/pub/test/install/git/check_out_with_trailing_slash_test.dart ('k') | sdk/lib/_internal/pub/test/install/git/different_repo_name_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/pub/test/install/git/dependency_name_match_pubspec_test.dart

diff --git a/sdk/lib/_internal/pub/test/install/git/dependency_name_match_pubspec_test.dart b/sdk/lib/_internal/pub/test/install/git/dependency_name_match_pubspec_test.dart

index c1e55720fed2a7798fc4dead62f82543b32de11d..c6f89ee7b56a5d64b89d5012e31889bd1da9d563 100644

--- a/sdk/lib/_internal/pub/test/install/git/dependency_name_match_pubspec_test.dart

+++ b/sdk/lib/_internal/pub/test/install/git/dependency_name_match_pubspec_test.dart

@@ -29,12 +29,8 @@ main() {

})

]).create();

- // TODO(nweiz): clean up this RegExp when either issue 4706 or 4707 is

- // fixed.

- schedulePub(args: ['install'],

- error: new RegExp(r'^The name you specified for your dependency, '

- '"weirdname", doesn\'t match the name "foo" in its '

- r'pubspec\.'),

- exitCode: 1);

+ pubInstall(error:

+ 'The name you specified for your dependency, "weirdname", doesn\'t '

+ 'match the name "foo" in its pubspec.');

});

}