Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(326)

Side by Side Diff: sdk/lib/_internal/pub/test/install/path/nonexistent_dir_test.dart

Issue 16034002: Use helper methods for running pub. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Get rid of unnecessary RegExps in tests. Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS d.file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS d.file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE d.file. 3 // BSD-style license that can be found in the LICENSE d.file.
4 4
5 import 'dart:io'; 5 import 'dart:io';
6 6
7 import 'package:pathos/path.dart' as path; 7 import 'package:pathos/path.dart' as path;
8 import 'package:scheduled_test/scheduled_test.dart'; 8 import 'package:scheduled_test/scheduled_test.dart';
9 9
10 import '../../descriptor.dart' as d; 10 import '../../descriptor.dart' as d;
11 import '../../test_pub.dart'; 11 import '../../test_pub.dart';
12 12
13 main() { 13 main() {
14 initConfig(); 14 initConfig();
15 integration('path dependency to non-existent directory', () { 15 integration('path dependency to non-existent directory', () {
16 var badPath = path.join(sandboxDir, "bad_path"); 16 var badPath = path.join(sandboxDir, "bad_path");
17 17
18 d.dir(appPath, [ 18 d.dir(appPath, [
19 d.pubspec({ 19 d.pubspec({
20 "name": "myapp", 20 "name": "myapp",
21 "dependencies": { 21 "dependencies": {
22 "foo": {"path": badPath} 22 "foo": {"path": badPath}
23 } 23 }
24 }) 24 })
25 ]).create(); 25 ]).create();
26 26
27 // TODO(rnystrom): The "\" in a Windows path gets treated like a regex 27 pubInstall(error: "Could not find package 'foo' at '$badPath'.");
28 // character, so hack escape. A better fix is to use a literal string
29 // instead of a RegExp to validate, but that requires us to move the
30 // stack traces out of the stderr when we invoke pub. See also: #4706.
31 var escapePath = badPath.replaceAll(r"\", r"\\");
32
33 schedulePub(args: ['install'],
34 error:
35 new RegExp("Could not find package 'foo' at '$escapePath'."),
36 exitCode: 1);
37 }); 28 });
38 } 29 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698