Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Unified Diff: sdk/lib/_internal/pub/test/pub_install_and_update_test.dart

Issue 16034002: Use helper methods for running pub. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Get rid of unnecessary RegExps in tests. Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/_internal/pub/test/pub_install_and_update_test.dart
diff --git a/sdk/lib/_internal/pub/test/pub_install_and_update_test.dart b/sdk/lib/_internal/pub/test/pub_install_and_update_test.dart
index 1cbd5a32e966af2bde8ffd555ae51eb110141ad4..d645071f09ec56049215ded6f3cb7094d03edea4 100644
--- a/sdk/lib/_internal/pub/test/pub_install_and_update_test.dart
+++ b/sdk/lib/_internal/pub/test/pub_install_and_update_test.dart
@@ -20,7 +20,8 @@ main() {
d.dir(appPath, []).create();
pubCommand(command,
- error: new RegExp(r'^Could not find a file named "pubspec.yaml"'));
+ error: new RegExp(r'^Could not find a file named "pubspec.yaml" '
+ r'in the directory .*\.$'));
});
integration('a pubspec with a "name" key', () {
@@ -28,9 +29,9 @@ main() {
d.pubspec({"dependencies": {"foo": null}})
]).create();
- pubCommand(command, error: new RegExp(
- r'^pubspec.yaml is missing the required "name" field '
- r'\(e\.g\. "name: myapp"\)\.'));
+ pubCommand(command, error:
+ 'pubspec.yaml is missing the required "name" field '
+ '(e.g. "name: myapp").');
});
});
@@ -112,7 +113,7 @@ main() {
]).create();
pubCommand(command,
- error: new RegExp(r"^Incompatible dependencies on 'baz':"));
+ error: new RegExp("^Incompatible dependencies on 'baz':\n"));
});
});
}
« no previous file with comments | « sdk/lib/_internal/pub/test/install/switch_source_test.dart ('k') | sdk/lib/_internal/pub/test/test_pub.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698