sdk/lib/_internal/pub/test/install/git/require_pubspec_name_test.dart - Issue 16034002: Use helper methods for running pub.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/pub/test/install/git/require_pubspec_name_test.dart

Issue 16034002: Use helper methods for running pub. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Get rid of unnecessary RegExps in tests. Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sdk/lib/_internal/pub/test/install/git/lock_version_test.dart ('k') | sdk/lib/_internal/pub/test/install/git/require_pubspec_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/pub/test/install/git/require_pubspec_name_test.dart

diff --git a/sdk/lib/_internal/pub/test/install/git/require_pubspec_name_test.dart b/sdk/lib/_internal/pub/test/install/git/require_pubspec_name_test.dart

index aad6a523000ff5542bdbe84df1afdc42e5ab78ce..eafd0678718fcad510c012b3e456c5939c77b1d8 100644

--- a/sdk/lib/_internal/pub/test/install/git/require_pubspec_name_test.dart

+++ b/sdk/lib/_internal/pub/test/install/git/require_pubspec_name_test.dart

@@ -24,9 +24,8 @@ main() {

// TODO(nweiz): clean up this RegExp when either issue 4706 or 4707 is

// fixed.

- schedulePub(args: ['install'],

- error: new RegExp(r'^Package "foo"' "'" 's pubspec.yaml file is '

- r'missing the required "name" field \(e\.g\. "name: foo"\)\.'),

- exitCode: 1);

+ pubInstall(error:

+ 'Package "foo"\'s pubspec.yaml file is '

+ 'missing the required "name" field (e.g. "name: foo").');

});

}