Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 14854010: On MIPS, keeps Object::null() in a register. (Closed)

Created:
7 years, 7 months ago by zra
Modified:
7 years, 7 months ago
Reviewers:
regis
CC:
reviews_dartlang.org
Visibility:
Public.

Description

On MIPS, keeps Object::null() in a register. On MIPS, we have a lot of registers, and we don't use very many of them. This change removes the second temporary register TMP2, and instead dedicates a register to holding Object::null(), which is used frequently for comparisons, etc.. Also, uses branch delay slot when leaving a dart frame and returning. R=regis@google.com Committed: https://code.google.com/p/dart/source/detail?r=22331

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+139 lines, -151 lines) Patch
M runtime/vm/assembler_mips.h View 2 chunks +11 lines, -6 lines 0 comments Download
M runtime/vm/assembler_mips.cc View 4 chunks +15 lines, -12 lines 0 comments Download
M runtime/vm/assembler_mips_test.cc View 2 chunks +2 lines, -1 line 0 comments Download
M runtime/vm/constants_mips.h View 1 2 chunks +8 lines, -2 lines 0 comments Download
M runtime/vm/debugger_mips.cc View 2 chunks +21 lines, -26 lines 0 comments Download
M runtime/vm/flow_graph_compiler_mips.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M runtime/vm/intermediate_language_mips.cc View 9 chunks +21 lines, -16 lines 0 comments Download
M runtime/vm/object_mips_test.cc View 1 chunk +1 line, -2 lines 0 comments Download
M runtime/vm/stub_code_arm.cc View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/stub_code_mips.cc View 37 chunks +56 lines, -77 lines 0 comments Download
M runtime/vm/stub_code_mips_test.cc View 2 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
zra
After going over the code, I wanted to try this out. It only reduces instruction ...
7 years, 7 months ago (2013-05-02 17:02:17 UTC) #1
zra
After going over the code, I wanted to try this out. It only reduces instruction ...
7 years, 7 months ago (2013-05-02 17:03:31 UTC) #2
regis
LGTM I do not know the answer about reserving a register for Object::null(). 3% is ...
7 years, 7 months ago (2013-05-02 17:18:16 UTC) #3
zra
On 2013/05/02 17:18:16, regis wrote: > LGTM > > I do not know the answer ...
7 years, 7 months ago (2013-05-02 17:29:33 UTC) #4
zra
7 years, 7 months ago (2013-05-02 17:53:43 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r22331 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698