Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(595)

Unified Diff: runtime/vm/constants_mips.h

Issue 14854010: On MIPS, keeps Object::null() in a register. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/assembler_mips_test.cc ('k') | runtime/vm/debugger_mips.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/constants_mips.h
===================================================================
--- runtime/vm/constants_mips.h (revision 22325)
+++ runtime/vm/constants_mips.h (working copy)
@@ -139,7 +139,6 @@
// Register aliases.
const Register TMP1 = AT; // Used as scratch register by assembler.
-const Register TMP2 = T9; // Used as scratch register by assembler.
const Register TMP = TMP1; // Arch independent flow graph compiler needs a
// Register called TMP.
const Register CTX = S6; // Caches current context in generated code.
@@ -147,10 +146,17 @@
const Register SPREG = SP; // Stack pointer register.
const Register FPREG = FP; // Frame pointer register.
+// NULLREG holds reinterpret_cast<intptr_t>(Object::null()).
+// TODO(zra): Is it worthwhile to devote a register to this? Investigate
+// performance effects when we are running on real hardware. Same with
+// CMPRES. Try moving CTX and PP to T8 and T9 and shifting kLastCpuRegister
+// down to S7.
+const Register NULLREG = T8;
+
// The code that generates a comparison can be far away from the code that
// generates the branch that uses the result of that comparison. In this case,
// CMPRES is used for the result of the comparison.
-const Register CMPRES = T8;
+const Register CMPRES = T9;
// Exception object is passed in this register to the catch handlers when an
// exception is thrown.
« no previous file with comments | « runtime/vm/assembler_mips_test.cc ('k') | runtime/vm/debugger_mips.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698