Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1072)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: runtime/vm/assembler_mips_test.cc

Issue 14854010: On MIPS, keeps Object::null() in a register. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/assembler_mips.cc ('k') | runtime/vm/constants_mips.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/assembler_mips_test.cc
===================================================================
--- runtime/vm/assembler_mips_test.cc (revision 22325)
+++ runtime/vm/assembler_mips_test.cc (working copy)
@@ -1060,6 +1060,7 @@
Register right = T1;
Register result = T2;
Register overflow = T3;
+ Register scratch = T4;
Label error, done;
__ LoadImmediate(V0, 1); // Success value.
@@ -1094,7 +1095,7 @@
__ bgez(overflow, &error); // INT_MIN - 1 overflows.
// result has 0x7fffffff.
- __ AdduDetectOverflow(result, result, result, overflow);
+ __ AdduDetectOverflow(result, result, result, overflow, scratch);
__ bgez(overflow, &error); // INT_MAX + INT_MAX overflows.
__ LoadImmediate(left, 0x80000000);
« no previous file with comments | « runtime/vm/assembler_mips.cc ('k') | runtime/vm/constants_mips.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698