Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 14426006: Rename dart:typeddata to dart:typed_data. (Closed)

Created:
7 years, 8 months ago by Mads Ager (google)
Modified:
7 years, 8 months ago
Reviewers:
floitsch, srdjan, siva
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+268 lines, -8098 lines) Patch
M compiler/java/com/google/dart/compiler/parser/DartParser.java View 1 chunk +1 line, -1 line 0 comments Download
M pkg/http/lib/http.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/http/lib/src/base_client.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/http/lib/src/byte_stream.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/http/lib/src/client.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/http/lib/src/request.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/http/lib/src/response.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/http/lib/src/utils.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/io.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/include/dart_api.h View 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/lib/core_patch.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/lib/math_patch.dart View 1 chunk +1 line, -1 line 0 comments Download
A + runtime/lib/typed_data.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + runtime/lib/typed_data.dart View 42 chunks +52 lines, -52 lines 0 comments Download
A + runtime/lib/typed_data_sources.gypi View 1 chunk +3 lines, -3 lines 0 comments Download
D runtime/lib/typeddata.cc View 1 chunk +0 lines, -443 lines 0 comments Download
D runtime/lib/typeddata.dart View 1 chunk +0 lines, -3191 lines 0 comments Download
D runtime/lib/typeddata_sources.gypi View 1 chunk +0 lines, -14 lines 0 comments Download
M runtime/tests/vm/dart/byte_array_optimized_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/tests/vm/dart/byte_array_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/benchmark_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/bootstrap.h View 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/vm/bootstrap.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/vm/class_finalizer.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/dart_api_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/dart_api_impl_test.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M runtime/vm/dart_api_message.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/intrinsifier.h View 2 chunks +27 lines, -27 lines 0 comments Download
M runtime/vm/intrinsifier.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M runtime/vm/intrinsifier_arm.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M runtime/vm/intrinsifier_ia32.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M runtime/vm/intrinsifier_mips.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M runtime/vm/intrinsifier_x64.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M runtime/vm/object.cc View 6 chunks +13 lines, -13 lines 0 comments Download
M runtime/vm/object_store.h View 4 chunks +10 lines, -10 lines 0 comments Download
M runtime/vm/object_store.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/snapshot_test.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M runtime/vm/symbols.h View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/vm.gypi View 8 chunks +29 lines, -29 lines 0 comments Download
A + sdk/lib/_internal/compiler/implementation/lib/typed_data_patch.dart View 1 chunk +2 lines, -2 lines 0 comments Download
D sdk/lib/_internal/compiler/implementation/lib/typeddata_patch.dart View 1 chunk +0 lines, -227 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/native_handler.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/compiler/implementation/tools/mini_parser.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/libraries.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M sdk/lib/html/dart2js/html_dart2js.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/html/html_common/html_common_dart2js.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/indexed_db/dart2js/indexed_db_dart2js.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/io/io.dart View 1 chunk +1 line, -1 line 0 comments Download
A + sdk/lib/typed_data/dart2js/typed_data_dart2js.dart View 1 chunk +1 line, -1 line 0 comments Download
A + sdk/lib/typed_data/typed_data.dart View 1 chunk +1 line, -1 line 0 comments Download
A + sdk/lib/typed_data/typed_data_sources.gypi View 1 chunk +1 line, -1 line 0 comments Download
D sdk/lib/typeddata/dart2js/typeddata_dart2js.dart View 1 chunk +0 lines, -2409 lines 0 comments Download
D sdk/lib/typeddata/typeddata.dart View 1 chunk +0 lines, -970 lines 0 comments Download
D sdk/lib/typeddata/typeddata_sources.gypi View 1 chunk +0 lines, -10 lines 0 comments Download
M sdk/lib/web_audio/dart2js/web_audio_dart2js.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/web_audio/dartium/web_audio_dartium.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/web_gl/dart2js/web_gl_dart2js.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/web_gl/dartium/web_gl_dartium.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/html/audiocontext_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/html/blob_constructor_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/html/crypto_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/html/postmessage_structured_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/html/transferables_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/html/typed_arrays_1_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/html/typed_arrays_2_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/html/typed_arrays_3_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/html/typed_arrays_4_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/html/typed_arrays_5_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/html/typed_arrays_arraybuffer_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/html/typed_arrays_dataview_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/html/typed_arrays_range_checks_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/html/url_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/html/utils.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/html/xhr_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/isolate/typed_data_message_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/analyzer/test_config.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/lib.status View 1 chunk +4 lines, -4 lines 0 comments Download
A + tests/lib/typed_data/float32x4_list_test.dart View 1 chunk +1 line, -1 line 0 comments Download
A + tests/lib/typed_data/float32x4_test.dart View 1 chunk +1 line, -1 line 0 comments Download
A + tests/lib/typed_data/float32x4_unbox_regress_test.dart View 1 chunk +1 line, -1 line 0 comments Download
D tests/lib/typeddata/float32x4_list_test.dart View 1 chunk +0 lines, -134 lines 0 comments Download
D tests/lib/typeddata/float32x4_test.dart View 1 chunk +0 lines, -376 lines 0 comments Download
D tests/lib/typeddata/float32x4_unbox_regress_test.dart View 1 chunk +0 lines, -56 lines 0 comments Download
M tests/standalone/byte_array_view_optimized_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/bytedata_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/float_array_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/int_array_deopt.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/int_array_load_elimination_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/int_array_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/file_typed_data_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/http_client_request_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/http_close_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/http_compression_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/http_parser_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/http_server_response_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/web_socket_protocol_processor_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/web_socket_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/standalone.status View 1 chunk +8 lines, -8 lines 0 comments Download
M tests/standalone/typed_array_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/typed_data_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/typed_data_view_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tools/create_sdk.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/dom/scripts/generator.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/dom/scripts/htmlrenamer.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/scripts/systemhtml.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/dom/templates/html/dart2js/html_dart2js.darttemplate View 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/templates/html/dart2js/indexed_db_dart2js.darttemplate View 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/templates/html/dart2js/web_audio_dart2js.darttemplate View 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/templates/html/dart2js/web_gl_dart2js.darttemplate View 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/templates/html/dartium/html_dartium.darttemplate View 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/templates/html/dartium/web_audio_dartium.darttemplate View 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/templates/html/dartium/web_gl_dartium.darttemplate View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Mads Ager (google)
7 years, 8 months ago (2013-04-23 10:40:23 UTC) #1
floitsch
LGTM. thanks.
7 years, 8 months ago (2013-04-23 11:49:01 UTC) #2
Mads Ager (google)
7 years, 8 months ago (2013-04-23 11:56:01 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 manually as r21871 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698