Issue 14251013: Rename unsubscribeOnError to cancelOnError.

Issue 14251013: Rename unsubscribeOnError to cancelOnError. (Closed)

Created:
7 years, 8 months ago by floitsch

Modified:
7 years, 8 months ago

Reviewers:
Lasse Reichstein Nielsen, Anders Johnsen

CC:
reviews_dartlang.org, Lasse Reichstein Nielsen

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Rename unsubscribeOnError to cancelOnError. Committed: https://code.google.com/p/dart/source/detail?r=21469

Patch Set 1 #

Total comments: 2

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+130 lines, -130 lines)			Patch
M	pkg/http/test/safe_http_server.dart	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	pkg/scheduled_test/lib/src/scheduled_server/safe_http_server.dart	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	pkg/scheduled_test/lib/src/utils.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/bin/socket_patch.dart	View	6 chunks	+10 lines, -10 lines	0 comments	Download
M	runtime/embedders/openglui/common/gl.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/async/stream.dart	View	23 chunks	+27 lines, -27 lines	2 comments	Download
M	sdk/lib/async/stream_impl.dart	View	7 chunks	+11 lines, -11 lines	0 comments	Download
M	sdk/lib/async/stream_pipe.dart	View	4 chunks	+8 lines, -8 lines	0 comments	Download
M	sdk/lib/html/dart2js/html_dart2js.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/html/dartium/html_dartium.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/io/file_impl.dart	View	3 chunks	+4 lines, -4 lines	0 comments	Download
M	sdk/lib/io/http_impl.dart	View	8 chunks	+11 lines, -11 lines	0 comments	Download
M	sdk/lib/io/http_parser.dart	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	sdk/lib/io/secure_server_socket.dart	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	sdk/lib/io/secure_socket.dart	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	sdk/lib/io/stdio.dart	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	sdk/lib/io/websocket_impl.dart	View	3 chunks	+4 lines, -4 lines	0 comments	Download
M	sdk/lib/isolate/isolate_stream.dart	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	tests/lib/async/event_helper.dart	View	2 chunks	+6 lines, -6 lines	0 comments	Download
M	tests/lib/async/stream_controller_test.dart	View	8 chunks	+8 lines, -8 lines	0 comments	Download
M	tests/lib/async/stream_state_helper.dart	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	tests/lib/async/stream_state_test.dart	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	tools/dom/src/EventStreamProvider.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	utils/pub/error_group.dart	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	utils/pub/io.dart	View	2 chunks	+5 lines, -5 lines	0 comments	Download
M	utils/pub/safe_http_server.dart	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	utils/pub/utils.dart	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

floitsch

Committed patchset #1 manually as r21469 (presubmit successful).

7 years, 8 months ago (2013-04-15 16:08:04 UTC) #3

Lasse Reichstein Nielsen

STV https://codereview.chromium.org/14251013/diff/1/sdk/lib/async/stream.dart File sdk/lib/async/stream.dart (right): https://codereview.chromium.org/14251013/diff/1/sdk/lib/async/stream.dart#newcode1101 sdk/lib/async/stream.dart:1101: /** Whether to unsubscribe when emitting an error. ...

7 years, 8 months ago (2013-04-15 16:11:02 UTC) #4

floitsch

7 years, 8 months ago (2013-04-15 16:13:51 UTC) #5

Message was sent while issue was closed.

https://codereview.chromium.org/14251013/diff/1/sdk/lib/async/stream.dart
File sdk/lib/async/stream.dart (right):

https://codereview.chromium.org/14251013/diff/1/sdk/lib/async/stream.dart#new...
sdk/lib/async/stream.dart:1101: /** Whether to unsubscribe when emitting an
error. */
On 2013/04/15 16:11:03, Lasse Reichstein Nielsen wrote:
> unsubscribe -> cancel :)

Please file a bug. I will do it later. ;P

Expand Messages | Collapse Messages