Make default argument to Iterable.join be "".

Make default argument to Iterable.join be "".

Committed: https://code.google.com/p/dart/source/detail?r=21193

[Lasse Reichstein Nielsen, 2013-04-10 08:28:23]

lgtm

[sra1, 2013-04-10 09:03:21]

https://codereview.chromium.org/13945009/diff/1018/sdk/lib/collection/list.dart
File sdk/lib/collection/list.dart (right):

https://codereview.chromium.org/13945009/diff/1018/sdk/lib/collection/list.da...
sdk/lib/collection/list.dart:186: if (separator != "") {
['x','y'].join(null)  ->  "xnully"

is this intentional?  It means any caller forwarding an optional parameter needs
to do explicit defaulting.

https://codereview.chromium.org/13945009/diff/1018/sdk/lib/collection/list.da...
sdk/lib/collection/list.dart:195: buffer.write("${this[i]}");
StringBuffer.write stringifies, do we need to do it again?

[floitsch, 2013-04-10 09:20:37]

https://codereview.chromium.org/13945009/diff/1018/sdk/lib/collection/list.dart
File sdk/lib/collection/list.dart (right):

https://codereview.chromium.org/13945009/diff/1018/sdk/lib/collection/list.da...
sdk/lib/collection/list.dart:186: if (separator != "") {
On 2013/04/10 09:03:22, sra1 wrote:
> ['x','y'].join(null)  ->  "xnully"
> 
> is this intentional?  It means any caller forwarding an optional parameter
needs
> to do explicit defaulting.

Changed. Now it's using "isEmpty" again. You still need to do explicit
defaulting. And that's intentional, but if you pass in 'null' it will throw now.
I actually had to change a test-case because it was triggering this behavior.

https://codereview.chromium.org/13945009/diff/1018/sdk/lib/collection/list.da...
sdk/lib/collection/list.dart:195: buffer.write("${this[i]}");
On 2013/04/10 09:03:22, sra1 wrote:
> StringBuffer.write stringifies, do we need to do it again?

Done.

[floitsch, 2013-04-10 11:28:57]

Committed patchset #3 manually as r21193 (presubmit successful).