sdk/lib/web_sql/dartium/web_sql_dartium.dart - Issue 13945009: Make default argument to Iterable.join be "".

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/web_sql/dartium/web_sql_dartium.dart

Issue 13945009: Make default argument to Iterable.join be "". (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Address comments. Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sdk/lib/web_sql/dartium/web_sql_dartium.dart

diff --git a/sdk/lib/web_sql/dartium/web_sql_dartium.dart b/sdk/lib/web_sql/dartium/web_sql_dartium.dart

index fd091c17a495873866321cfb775e13ac4b30cc1a..006f02ac953019f3b29789cebcdbd7694a0364fc 100644

--- a/sdk/lib/web_sql/dartium/web_sql_dartium.dart

+++ b/sdk/lib/web_sql/dartium/web_sql_dartium.dart

@@ -253,7 +253,7 @@ class SqlResultSetRowList extends NativeFieldWrapperClass1 implements List<Map>

void forEach(void f(Map element)) => IterableMixinWorkaround.forEach(this, f);

- String join([String separator]) =>

+ String join([String separator = ""]) =>

IterableMixinWorkaround.joinList(this, separator);

Iterable map(f(Map element)) =>

« no previous file with comments | « sdk/lib/web_sql/dart2js/web_sql_dart2js.dart ('k') | tests/corelib/iterable_join_test.dart » ('j') | no next file with comments »