tests/corelib/iterable_join_test.dart - Issue 13945009: Make default argument to Iterable.join be "".

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/corelib/iterable_join_test.dart

Issue 13945009: Make default argument to Iterable.join be "". (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Address comments. Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tests/corelib/iterable_join_test.dart

diff --git a/tests/corelib/iterable_join_test.dart b/tests/corelib/iterable_join_test.dart

index c47f782ee68c501b148bf47ae517b8f27b00b224..e374be441c90f5fb391df124ddc3ff5597ae775a 100644

--- a/tests/corelib/iterable_join_test.dart

+++ b/tests/corelib/iterable_join_test.dart

@@ -9,8 +9,12 @@ class IC {

String toString() => "${count++}";

}

-testJoin(String expect, Iterable iterable, [String separator]) {

- Expect.equals(expect, iterable.join(separator));

+testJoin(String expect, Iterable iterable, [String separator = ""]) {

+ if (?separator) {

+ Expect.equals(expect, iterable.join(separator));

+ } else {

+ Expect.equals(expect, iterable.join());

+ }

}

testCollections() {

« no previous file with comments | « sdk/lib/web_sql/dartium/web_sql_dartium.dart ('k') | tools/dom/src/CssClassSet.dart » ('j') | no next file with comments »