samples/swarm/swarm_ui_lib/observable/observable.dart - Issue 13945009: Make default argument to Iterable.join be "".

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: samples/swarm/swarm_ui_lib/observable/observable.dart

Issue 13945009: Make default argument to Iterable.join be "". (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Address comments. Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: samples/swarm/swarm_ui_lib/observable/observable.dart

diff --git a/samples/swarm/swarm_ui_lib/observable/observable.dart b/samples/swarm/swarm_ui_lib/observable/observable.dart

index 1b3c46d30a8c95eab01652962214247f8f94e1a7..89d4a16bd75db5dccbb89bde32aa95ddc00ab35e 100644

--- a/samples/swarm/swarm_ui_lib/observable/observable.dart

+++ b/samples/swarm/swarm_ui_lib/observable/observable.dart

@@ -302,7 +302,7 @@ class ObservableList<T>

bool every(bool f(T element)) => _internal.every(f);

bool any(bool f(T element)) => _internal.any(f);

void forEach(void f(T element)) { _internal.forEach(f); }

- String join([String separator]) => _internal.join(separator);

+ String join([String separator = ""]) => _internal.join(separator);

T firstWhere(bool test(T value), {T orElse()}) {

return _internal.firstWhere(test, orElse: orElse);

}

« no previous file with comments | « runtime/lib/typeddata.dart ('k') | sdk/lib/_collection_dev/iterable.dart » ('j') | no next file with comments »