Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Side by Side Diff: sdk/lib/svg/dart2js/svg_dart2js.dart

Issue 13945009: Make default argument to Iterable.join be "". (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Address comments. Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « sdk/lib/io/io_sink.dart ('k') | sdk/lib/svg/dartium/svg_dartium.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 library dart.dom.svg; 1 library dart.dom.svg;
2 2
3 import 'dart:async'; 3 import 'dart:async';
4 import 'dart:collection'; 4 import 'dart:collection';
5 import 'dart:html'; 5 import 'dart:html';
6 import 'dart:html_common'; 6 import 'dart:html_common';
7 import 'dart:_js_helper' show Creates, Returns, JavaScriptIndexingBehavior, JSNa me; 7 import 'dart:_js_helper' show Creates, Returns, JavaScriptIndexingBehavior, JSNa me;
8 import 'dart:_foreign_helper' show JS; 8 import 'dart:_foreign_helper' show JS;
9 // DO NOT EDIT - unless you are editing documentation as per: 9 // DO NOT EDIT - unless you are editing documentation as per:
10 // https://code.google.com/p/dart/wiki/ContributingHTMLDocumentation 10 // https://code.google.com/p/dart/wiki/ContributingHTMLDocumentation
(...skipping 3024 matching lines...) Expand 10 before | Expand all | Expand 10 after
3035 } 3035 }
3036 3036
3037 dynamic fold(dynamic initialValue, dynamic combine(dynamic, Length)) { 3037 dynamic fold(dynamic initialValue, dynamic combine(dynamic, Length)) {
3038 return IterableMixinWorkaround.fold(this, initialValue, combine); 3038 return IterableMixinWorkaround.fold(this, initialValue, combine);
3039 } 3039 }
3040 3040
3041 bool contains(Length element) => IterableMixinWorkaround.contains(this, elemen t); 3041 bool contains(Length element) => IterableMixinWorkaround.contains(this, elemen t);
3042 3042
3043 void forEach(void f(Length element)) => IterableMixinWorkaround.forEach(this, f); 3043 void forEach(void f(Length element)) => IterableMixinWorkaround.forEach(this, f);
3044 3044
3045 String join([String separator]) => 3045 String join([String separator = ""]) =>
3046 IterableMixinWorkaround.joinList(this, separator); 3046 IterableMixinWorkaround.joinList(this, separator);
3047 3047
3048 Iterable map(f(Length element)) => 3048 Iterable map(f(Length element)) =>
3049 IterableMixinWorkaround.mapList(this, f); 3049 IterableMixinWorkaround.mapList(this, f);
3050 3050
3051 Iterable<Length> where(bool f(Length element)) => 3051 Iterable<Length> where(bool f(Length element)) =>
3052 IterableMixinWorkaround.where(this, f); 3052 IterableMixinWorkaround.where(this, f);
3053 3053
3054 Iterable expand(Iterable f(Length element)) => 3054 Iterable expand(Iterable f(Length element)) =>
3055 IterableMixinWorkaround.expand(this, f); 3055 IterableMixinWorkaround.expand(this, f);
(...skipping 624 matching lines...) Expand 10 before | Expand all | Expand 10 after
3680 } 3680 }
3681 3681
3682 dynamic fold(dynamic initialValue, dynamic combine(dynamic, Number)) { 3682 dynamic fold(dynamic initialValue, dynamic combine(dynamic, Number)) {
3683 return IterableMixinWorkaround.fold(this, initialValue, combine); 3683 return IterableMixinWorkaround.fold(this, initialValue, combine);
3684 } 3684 }
3685 3685
3686 bool contains(Number element) => IterableMixinWorkaround.contains(this, elemen t); 3686 bool contains(Number element) => IterableMixinWorkaround.contains(this, elemen t);
3687 3687
3688 void forEach(void f(Number element)) => IterableMixinWorkaround.forEach(this, f); 3688 void forEach(void f(Number element)) => IterableMixinWorkaround.forEach(this, f);
3689 3689
3690 String join([String separator]) => 3690 String join([String separator = ""]) =>
3691 IterableMixinWorkaround.joinList(this, separator); 3691 IterableMixinWorkaround.joinList(this, separator);
3692 3692
3693 Iterable map(f(Number element)) => 3693 Iterable map(f(Number element)) =>
3694 IterableMixinWorkaround.mapList(this, f); 3694 IterableMixinWorkaround.mapList(this, f);
3695 3695
3696 Iterable<Number> where(bool f(Number element)) => 3696 Iterable<Number> where(bool f(Number element)) =>
3697 IterableMixinWorkaround.where(this, f); 3697 IterableMixinWorkaround.where(this, f);
3698 3698
3699 Iterable expand(Iterable f(Number element)) => 3699 Iterable expand(Iterable f(Number element)) =>
3700 IterableMixinWorkaround.expand(this, f); 3700 IterableMixinWorkaround.expand(this, f);
(...skipping 855 matching lines...) Expand 10 before | Expand all | Expand 10 after
4556 } 4556 }
4557 4557
4558 dynamic fold(dynamic initialValue, dynamic combine(dynamic, PathSeg)) { 4558 dynamic fold(dynamic initialValue, dynamic combine(dynamic, PathSeg)) {
4559 return IterableMixinWorkaround.fold(this, initialValue, combine); 4559 return IterableMixinWorkaround.fold(this, initialValue, combine);
4560 } 4560 }
4561 4561
4562 bool contains(PathSeg element) => IterableMixinWorkaround.contains(this, eleme nt); 4562 bool contains(PathSeg element) => IterableMixinWorkaround.contains(this, eleme nt);
4563 4563
4564 void forEach(void f(PathSeg element)) => IterableMixinWorkaround.forEach(this, f); 4564 void forEach(void f(PathSeg element)) => IterableMixinWorkaround.forEach(this, f);
4565 4565
4566 String join([String separator]) => 4566 String join([String separator = ""]) =>
4567 IterableMixinWorkaround.joinList(this, separator); 4567 IterableMixinWorkaround.joinList(this, separator);
4568 4568
4569 Iterable map(f(PathSeg element)) => 4569 Iterable map(f(PathSeg element)) =>
4570 IterableMixinWorkaround.mapList(this, f); 4570 IterableMixinWorkaround.mapList(this, f);
4571 4571
4572 Iterable<PathSeg> where(bool f(PathSeg element)) => 4572 Iterable<PathSeg> where(bool f(PathSeg element)) =>
4573 IterableMixinWorkaround.where(this, f); 4573 IterableMixinWorkaround.where(this, f);
4574 4574
4575 Iterable expand(Iterable f(PathSeg element)) => 4575 Iterable expand(Iterable f(PathSeg element)) =>
4576 IterableMixinWorkaround.expand(this, f); 4576 IterableMixinWorkaround.expand(this, f);
(...skipping 885 matching lines...) Expand 10 before | Expand all | Expand 10 after
5462 } 5462 }
5463 5463
5464 dynamic fold(dynamic initialValue, dynamic combine(dynamic, String)) { 5464 dynamic fold(dynamic initialValue, dynamic combine(dynamic, String)) {
5465 return IterableMixinWorkaround.fold(this, initialValue, combine); 5465 return IterableMixinWorkaround.fold(this, initialValue, combine);
5466 } 5466 }
5467 5467
5468 bool contains(String element) => IterableMixinWorkaround.contains(this, elemen t); 5468 bool contains(String element) => IterableMixinWorkaround.contains(this, elemen t);
5469 5469
5470 void forEach(void f(String element)) => IterableMixinWorkaround.forEach(this, f); 5470 void forEach(void f(String element)) => IterableMixinWorkaround.forEach(this, f);
5471 5471
5472 String join([String separator]) => 5472 String join([String separator = ""]) =>
5473 IterableMixinWorkaround.joinList(this, separator); 5473 IterableMixinWorkaround.joinList(this, separator);
5474 5474
5475 Iterable map(f(String element)) => 5475 Iterable map(f(String element)) =>
5476 IterableMixinWorkaround.mapList(this, f); 5476 IterableMixinWorkaround.mapList(this, f);
5477 5477
5478 Iterable<String> where(bool f(String element)) => 5478 Iterable<String> where(bool f(String element)) =>
5479 IterableMixinWorkaround.where(this, f); 5479 IterableMixinWorkaround.where(this, f);
5480 5480
5481 Iterable expand(Iterable f(String element)) => 5481 Iterable expand(Iterable f(String element)) =>
5482 IterableMixinWorkaround.expand(this, f); 5482 IterableMixinWorkaround.expand(this, f);
(...skipping 1158 matching lines...) Expand 10 before | Expand all | Expand 10 after
6641 } 6641 }
6642 6642
6643 dynamic fold(dynamic initialValue, dynamic combine(dynamic, Transform)) { 6643 dynamic fold(dynamic initialValue, dynamic combine(dynamic, Transform)) {
6644 return IterableMixinWorkaround.fold(this, initialValue, combine); 6644 return IterableMixinWorkaround.fold(this, initialValue, combine);
6645 } 6645 }
6646 6646
6647 bool contains(Transform element) => IterableMixinWorkaround.contains(this, ele ment); 6647 bool contains(Transform element) => IterableMixinWorkaround.contains(this, ele ment);
6648 6648
6649 void forEach(void f(Transform element)) => IterableMixinWorkaround.forEach(thi s, f); 6649 void forEach(void f(Transform element)) => IterableMixinWorkaround.forEach(thi s, f);
6650 6650
6651 String join([String separator]) => 6651 String join([String separator = ""]) =>
6652 IterableMixinWorkaround.joinList(this, separator); 6652 IterableMixinWorkaround.joinList(this, separator);
6653 6653
6654 Iterable map(f(Transform element)) => 6654 Iterable map(f(Transform element)) =>
6655 IterableMixinWorkaround.mapList(this, f); 6655 IterableMixinWorkaround.mapList(this, f);
6656 6656
6657 Iterable<Transform> where(bool f(Transform element)) => 6657 Iterable<Transform> where(bool f(Transform element)) =>
6658 IterableMixinWorkaround.where(this, f); 6658 IterableMixinWorkaround.where(this, f);
6659 6659
6660 Iterable expand(Iterable f(Transform element)) => 6660 Iterable expand(Iterable f(Transform element)) =>
6661 IterableMixinWorkaround.expand(this, f); 6661 IterableMixinWorkaround.expand(this, f);
(...skipping 517 matching lines...) Expand 10 before | Expand all | Expand 10 after
7179 } 7179 }
7180 7180
7181 dynamic fold(dynamic initialValue, dynamic combine(dynamic, ElementInstance)) { 7181 dynamic fold(dynamic initialValue, dynamic combine(dynamic, ElementInstance)) {
7182 return IterableMixinWorkaround.fold(this, initialValue, combine); 7182 return IterableMixinWorkaround.fold(this, initialValue, combine);
7183 } 7183 }
7184 7184
7185 bool contains(ElementInstance element) => IterableMixinWorkaround.contains(thi s, element); 7185 bool contains(ElementInstance element) => IterableMixinWorkaround.contains(thi s, element);
7186 7186
7187 void forEach(void f(ElementInstance element)) => IterableMixinWorkaround.forEa ch(this, f); 7187 void forEach(void f(ElementInstance element)) => IterableMixinWorkaround.forEa ch(this, f);
7188 7188
7189 String join([String separator]) => 7189 String join([String separator = ""]) =>
7190 IterableMixinWorkaround.joinList(this, separator); 7190 IterableMixinWorkaround.joinList(this, separator);
7191 7191
7192 Iterable map(f(ElementInstance element)) => 7192 Iterable map(f(ElementInstance element)) =>
7193 IterableMixinWorkaround.mapList(this, f); 7193 IterableMixinWorkaround.mapList(this, f);
7194 7194
7195 Iterable<ElementInstance> where(bool f(ElementInstance element)) => 7195 Iterable<ElementInstance> where(bool f(ElementInstance element)) =>
7196 IterableMixinWorkaround.where(this, f); 7196 IterableMixinWorkaround.where(this, f);
7197 7197
7198 Iterable expand(Iterable f(ElementInstance element)) => 7198 Iterable expand(Iterable f(ElementInstance element)) =>
7199 IterableMixinWorkaround.expand(this, f); 7199 IterableMixinWorkaround.expand(this, f);
(...skipping 431 matching lines...) Expand 10 before | Expand all | Expand 10 after
7631 7631
7632 7632
7633 @DocsEditable 7633 @DocsEditable
7634 @DomName('SVGVKernElement') 7634 @DomName('SVGVKernElement')
7635 abstract class _SVGVKernElement extends SvgElement native "*SVGVKernElement" { 7635 abstract class _SVGVKernElement extends SvgElement native "*SVGVKernElement" {
7636 7636
7637 @DomName('SVGVKernElement.SVGVKernElement') 7637 @DomName('SVGVKernElement.SVGVKernElement')
7638 @DocsEditable 7638 @DocsEditable
7639 factory _SVGVKernElement() => _SvgElementFactoryProvider.createSvgElement_tag( "vkern"); 7639 factory _SVGVKernElement() => _SvgElementFactoryProvider.createSvgElement_tag( "vkern");
7640 } 7640 }
OLDNEW
« no previous file with comments | « sdk/lib/io/io_sink.dart ('k') | sdk/lib/svg/dartium/svg_dartium.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698