Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1313893004: Move isPrivateName and isPublicName to Name. (Closed)

Created:
5 years, 3 months ago by Johnni Winther
Modified:
5 years, 3 months ago
Reviewers:
sigurdm
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -47 lines) Patch
M pkg/compiler/lib/src/compiler.dart View 2 chunks +0 lines, -7 lines 0 comments Download
M pkg/compiler/lib/src/dart_backend/dart_backend.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/compiler/lib/src/dart_backend/placeholder_collector.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/elements/common.dart View 3 chunks +2 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/elements/elements.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/elements/modelx.dart View 2 chunks +2 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/elements/names.dart View 2 chunks +9 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/backend.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_backend/js_backend.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/compiler/lib/src/resolution/class_hierarchy.dart View 2 chunks +2 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/resolution/class_members.dart View 2 chunks +2 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/resolution/constructors.dart View 2 chunks +2 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/resolution/members.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/compiler/lib/src/resolution/registry.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/compiler/lib/src/resolution/signatures.dart View 2 chunks +2 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/resolution/typedefs.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/compiler/lib/src/typechecker.dart View 2 chunks +2 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/use_unused_api.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
Johnni Winther
5 years, 3 months ago (2015-08-28 12:13:50 UTC) #2
sigurdm
LGTM
5 years, 3 months ago (2015-08-31 08:05:14 UTC) #3
Johnni Winther
5 years, 3 months ago (2015-08-31 08:26:59 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
838c8d0423ea06f5f922c1d974604d407993b7b9 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698