Move isPrivateName and isPublicName to Name.

pkg/compiler/lib/src/elements/common.dart

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /// Mixins that implement convenience methods on [Element] subclasses.
 
 library elements.common;
 
 import '../common/names.dart' show
     Names,
     Uris;
-import '../compiler.dart' show
-    Compiler,
-    isPrivateName;
 import '../dart_types.dart' show
     DartType,
     InterfaceType,
     FunctionType;
 import '../util/util.dart' show
     Link;
 
 import 'elements.dart';
 
 abstract class ElementCommon implements Element {
@@ skipping 247 matching lines @@
     return lookupSuperMemberInLibrary(memberName, library);
   }
 
   /**
    * Lookup super members for the class that is accessible in [library].
    * This will ignore constructors.
    */
   @override
   Element lookupSuperMemberInLibrary(String memberName,
                                      LibraryElement library) {
-    bool isPrivate = isPrivateName(memberName);
+    bool isPrivate = Name.isPrivateName(memberName);
     for (ClassElement s = superclass; s != null; s = s.superclass) {
       // Private members from a different library are not visible.
       if (isPrivate && !identical(library, s.library)) continue;
       Element e = s.lookupLocalMember(memberName);
       if (e == null) continue;
       // Static members are not inherited.
       if (e.isStatic) continue;
       return e;
     }
     return null;
@@ skipping 88 matching lines @@
    * Returns true if the [fieldMember] shadows another field.  The given
    * [fieldMember] must be a member of this class, i.e. if there is a field of
    * the same name in the superclass chain.
    *
    * This method also works if the [fieldMember] is private.
    */
   @override
   bool hasFieldShadowedBy(Element fieldMember) {
     assert(fieldMember.isField);
     String fieldName = fieldMember.name;
-    bool isPrivate = isPrivateName(fieldName);
+    bool isPrivate = Name.isPrivateName(fieldName);
     LibraryElement memberLibrary = fieldMember.library;
     ClassElement lookupClass = this.superclass;
     while (lookupClass != null) {
       Element foundMember = lookupClass.lookupLocalMember(fieldName);
       if (foundMember != null) {
         if (foundMember.isField) {
           if (!isPrivate || memberLibrary == foundMember.library) {
             // Private fields can only be shadowed by a field declared in the
             // same library.
             return true;
@@ skipping 91 matching lines @@
       // this signature must not have more required parameters.  Having more
       // optional parameters is not a problem, they simply are never provided
       // by call sites of a call to a method with the other signature.
       int otherTotalCount = signature.parameterCount;
       return requiredParameterCount <= otherTotalCount
           && parameterCount >= otherTotalCount;
     }
     return true;
   }
 }