pkg/compiler/lib/src/js_backend/backend.dart - Issue 1313893004: Move isPrivateName and isPublicName to Name.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/js_backend/backend.dart

Issue 1313893004: Move isPrivateName and isPublicName to Name. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/compiler/lib/src/js_backend/backend.dart

diff --git a/pkg/compiler/lib/src/js_backend/backend.dart b/pkg/compiler/lib/src/js_backend/backend.dart

index 8b61544c84b7d86bb498eceb543dcbd3c27a278e..ce801a9b8414fb83ec11b204a952f63a9ed69dcb 100644

--- a/pkg/compiler/lib/src/js_backend/backend.dart

+++ b/pkg/compiler/lib/src/js_backend/backend.dart

@@ -1048,7 +1048,7 @@ class JavaScriptBackend extends Backend {

ClassElement implementation = cls.patch != null ? cls.patch : cls;

ConstructorElement ctor = implementation.lookupConstructor(name);

if (ctor == null

- || (isPrivateName(name)

+ || (Name.isPrivateName(name)

&& ctor.library != mapLiteralClass.library)) {

compiler.internalError(mapLiteralClass,

"Map literal class $mapLiteralClass missing "