Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(802)

Unified Diff: pkg/compiler/lib/src/resolution/constructors.dart

Issue 1313893004: Move isPrivateName and isPublicName to Name. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/compiler/lib/src/resolution/class_members.dart ('k') | pkg/compiler/lib/src/resolution/members.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/resolution/constructors.dart
diff --git a/pkg/compiler/lib/src/resolution/constructors.dart b/pkg/compiler/lib/src/resolution/constructors.dart
index 67e9461470d5be374c0d6fe1698ae81993e614b1..cff366c5327ee36d067c8a8e54f20122f607e92c 100644
--- a/pkg/compiler/lib/src/resolution/constructors.dart
+++ b/pkg/compiler/lib/src/resolution/constructors.dart
@@ -4,8 +4,7 @@
library dart2js.resolution.constructors;
import '../compiler.dart' show
- Compiler,
- isPrivateName;
+ Compiler;
import '../constants/constructors.dart' show
GenerativeConstantConstructor,
RedirectingGenerativeConstantConstructor;
@@ -459,7 +458,7 @@ class ConstructorResolver extends CommonResolverVisitor<Element> {
cls.ensureResolved(compiler);
Element result = cls.lookupConstructor(constructorName);
// TODO(johnniwinther): Use [Name] for lookup.
- if (isPrivateName(constructorName) &&
+ if (Name.isPrivateName(constructorName) &&
resolver.enclosingElement.library != cls.library) {
result = null;
}
« no previous file with comments | « pkg/compiler/lib/src/resolution/class_members.dart ('k') | pkg/compiler/lib/src/resolution/members.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698