Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Unified Diff: pkg/compiler/lib/src/elements/common.dart

Issue 1313893004: Move isPrivateName and isPublicName to Name. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/elements/common.dart
diff --git a/pkg/compiler/lib/src/elements/common.dart b/pkg/compiler/lib/src/elements/common.dart
index f70e43f330ebbd23593e8013799cc363a87f7ce0..5320fcb28f9b72c009762ce3226c8bf0db520def 100644
--- a/pkg/compiler/lib/src/elements/common.dart
+++ b/pkg/compiler/lib/src/elements/common.dart
@@ -9,9 +9,6 @@ library elements.common;
import '../common/names.dart' show
Names,
Uris;
-import '../compiler.dart' show
- Compiler,
- isPrivateName;
import '../dart_types.dart' show
DartType,
InterfaceType,
@@ -279,7 +276,7 @@ abstract class ClassElementCommon implements ClassElement {
@override
Element lookupSuperMemberInLibrary(String memberName,
LibraryElement library) {
- bool isPrivate = isPrivateName(memberName);
+ bool isPrivate = Name.isPrivateName(memberName);
for (ClassElement s = superclass; s != null; s = s.superclass) {
// Private members from a different library are not visible.
if (isPrivate && !identical(library, s.library)) continue;
@@ -388,7 +385,7 @@ abstract class ClassElementCommon implements ClassElement {
bool hasFieldShadowedBy(Element fieldMember) {
assert(fieldMember.isField);
String fieldName = fieldMember.name;
- bool isPrivate = isPrivateName(fieldName);
+ bool isPrivate = Name.isPrivateName(fieldName);
LibraryElement memberLibrary = fieldMember.library;
ClassElement lookupClass = this.superclass;
while (lookupClass != null) {
« no previous file with comments | « pkg/compiler/lib/src/dart_backend/placeholder_collector.dart ('k') | pkg/compiler/lib/src/elements/elements.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698