- Ensure that HandleScope is initialized with a thread. (Remove

- Ensure that HandleScope is initialized with a thread. (Remove
  deprecated isolate based API.)
- Update all code impacted by this change. E.g. DARTSCOPE
- TEST_CASE now passes the current thread as a parameter to the   unit test.

BUG=
R=asiva@google.com

Committed: https://github.com/dart-lang/sdk/commit/4bd7cdc75c97da7e77849de479f13575f0fb7b0e

[Ivan Posva, 2015-09-01 18:16:41]

iposva@google.com changed reviewers:
+ asiva@google.com

[siva, 2015-09-01 23:38:16]

lgtm

https://codereview.chromium.org/1310463005/diff/1/runtime/vm/dart_api_impl.cc
File runtime/vm/dart_api_impl.cc (right):

https://codereview.chromium.org/1310463005/diff/1/runtime/vm/dart_api_impl.cc...
runtime/vm/dart_api_impl.cc:1360: Thread* thread = Thread::Current();
Would it be uniform to name this variable T
Thread* T = Thread::Current();

https://codereview.chromium.org/1310463005/diff/1/runtime/vm/dart_api_impl.cc...
runtime/vm/dart_api_impl.cc:1391: Thread* thread = Thread::Current();
Ditto.

https://codereview.chromium.org/1310463005/diff/1/runtime/vm/dart_api_impl.cc...
runtime/vm/dart_api_impl.cc:1650: Isolate* isolate = thread->isolate();
Ditto comment about using T, I

https://codereview.chromium.org/1310463005/diff/1/runtime/vm/snapshot_test.cc
File runtime/vm/snapshot_test.cc (right):

https://codereview.chromium.org/1310463005/diff/1/runtime/vm/snapshot_test.cc...
runtime/vm/snapshot_test.cc:727: {                                              
                             \
Why did you get rid of the StackZone here?

https://codereview.chromium.org/1310463005/diff/1/runtime/vm/snapshot_test.cc...
runtime/vm/snapshot_test.cc:750: {                                              
                             \
Ditto question.

[Ivan Posva, 2015-09-02 00:03:33]

Thanks!

-Ivan

https://codereview.chromium.org/1310463005/diff/1/runtime/vm/dart_api_impl.cc
File runtime/vm/dart_api_impl.cc (right):

https://codereview.chromium.org/1310463005/diff/1/runtime/vm/dart_api_impl.cc...
runtime/vm/dart_api_impl.cc:1360: Thread* thread = Thread::Current();
On 2015/09/01 23:38:16, siva wrote:
> Would it be uniform to name this variable T
> Thread* T = Thread::Current();

Done + renamed isolate->I.

https://codereview.chromium.org/1310463005/diff/1/runtime/vm/dart_api_impl.cc...
runtime/vm/dart_api_impl.cc:1391: Thread* thread = Thread::Current();
On 2015/09/01 23:38:16, siva wrote:
> Ditto.

Done.

https://codereview.chromium.org/1310463005/diff/1/runtime/vm/dart_api_impl.cc...
runtime/vm/dart_api_impl.cc:1650: Isolate* isolate = thread->isolate();
On 2015/09/01 23:38:16, siva wrote:
> Ditto comment about using T, I

Done.

https://codereview.chromium.org/1310463005/diff/1/runtime/vm/snapshot_test.cc
File runtime/vm/snapshot_test.cc (right):

https://codereview.chromium.org/1310463005/diff/1/runtime/vm/snapshot_test.cc...
runtime/vm/snapshot_test.cc:727: {                                              
                             \
On 2015/09/01 23:38:16, siva wrote:
> Why did you get rid of the StackZone here?

Reverted.

https://codereview.chromium.org/1310463005/diff/1/runtime/vm/snapshot_test.cc...
runtime/vm/snapshot_test.cc:750: {                                              
                             \
On 2015/09/01 23:38:16, siva wrote:
> Ditto question.

ditto.

[Ivan Posva, 2015-09-02 00:19:02]

Committed patchset #2 (id:20001) manually as
4bd7cdc75c97da7e77849de479f13575f0fb7b0e (presubmit successful).