runtime/vm/isolate.h - Issue 1310463005: - Ensure that HandleScope is initialized with a thread. (Remove

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/isolate.h

Issue 1310463005: - Ensure that HandleScope is initialized with a thread. (Remove (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Address review comments Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/isolate.h

diff --git a/runtime/vm/isolate.h b/runtime/vm/isolate.h

index 90f97c4a697ddf988db1bf785b7cbb0ad8c77144..b8e7a4ca40fa254765ca3b75f3fc121eb9d50362 100644

--- a/runtime/vm/isolate.h

+++ b/runtime/vm/isolate.h

@@ -1102,8 +1102,8 @@ class IsolateSpawnState {

Isolate::Flags* isolate_flags() { return &isolate_flags_; }

RawObject* ResolveFunction();

- RawInstance* BuildArgs(Zone* zone);

- RawInstance* BuildMessage(Zone* zone);

+ RawInstance* BuildArgs(Thread* thread);

+ RawInstance* BuildMessage(Thread* thread);

void Cleanup();

private:

« no previous file with comments | « runtime/vm/handles_test.cc ('k') | runtime/vm/isolate.cc » ('j') | no next file with comments »