runtime/vm/profiler_service.h - Issue 1310463005: - Ensure that HandleScope is initialized with a thread. (Remove

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/profiler_service.h

Issue 1310463005: - Ensure that HandleScope is initialized with a thread. (Remove (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Address review comments Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/profiler_service.h

diff --git a/runtime/vm/profiler_service.h b/runtime/vm/profiler_service.h

index 7f0b9a3e018e03b0fe09f716c5f84c569af6f9e5..621db01286e01b11f08c92ee015e9650b2a47e6e 100644

--- a/runtime/vm/profiler_service.h

+++ b/runtime/vm/profiler_service.h

@@ -387,7 +387,7 @@ class ProfilerService : public AllStatic {

static void ClearSamples();

private:

- static void PrintJSONImpl(Isolate* isolate,

+ static void PrintJSONImpl(Thread* thread,

JSONStream* stream,

Profile::TagOrder tag_order,

intptr_t extra_tags,

« no previous file with comments | « runtime/vm/object_test.cc ('k') | runtime/vm/profiler_service.cc » ('j') | no next file with comments »