runtime/vm/message_handler.h - Issue 1310463005: - Ensure that HandleScope is initialized with a thread. (Remove

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/message_handler.h

Issue 1310463005: - Ensure that HandleScope is initialized with a thread. (Remove (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Address review comments Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/message_handler.h

diff --git a/runtime/vm/message_handler.h b/runtime/vm/message_handler.h

index 78c5f6c7e5ec4173641a9f06b21b32b9fb365752..4a939ae522101b564d5a4d7a463274fcd32bd6e4 100644

--- a/runtime/vm/message_handler.h

+++ b/runtime/vm/message_handler.h

@@ -184,6 +184,9 @@ class MessageHandler {

virtual void NotifyPauseOnStart() {}

virtual void NotifyPauseOnExit() {}

+ // TODO(iposva): Set a local field before entering MessageHandler methods.

+ Thread* thread() const { return Thread::Current(); }

private:

friend class PortMap;

friend class MessageHandlerTestPeer;

« no previous file with comments | « runtime/vm/isolate.cc ('k') | runtime/vm/metrics_test.cc » ('j') | no next file with comments »