runtime/vm/runtime_entry.h - Issue 1310463005: - Ensure that HandleScope is initialized with a thread. (Remove

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/runtime_entry.h

Issue 1310463005: - Ensure that HandleScope is initialized with a thread. (Remove (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Address review comments Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/runtime_entry.h

diff --git a/runtime/vm/runtime_entry.h b/runtime/vm/runtime_entry.h

index 2d4790ff75bc0a0a20b6519bcd0bdd9a531e29db..9083718574c5b1d5c4dc549e34c95c07002cfcdb 100644

--- a/runtime/vm/runtime_entry.h

+++ b/runtime/vm/runtime_entry.h

@@ -142,7 +142,7 @@ class RuntimeEntry : public ValueObject {

ASSERT(thread == Thread::Current()); \

Isolate* isolate = thread->isolate(); \

StackZone zone(thread); \

- HANDLESCOPE(isolate); \

+ HANDLESCOPE(thread); \

DRT_Helper##name(isolate, thread, zone.GetZone(), arguments); \

} \

VERIFY_ON_TRANSITION; \

« no previous file with comments | « runtime/vm/profiler_test.cc ('k') | runtime/vm/service.cc » ('j') | no next file with comments »