Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(699)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1310253007: Make pub lish validation gitignore-aware. (Closed)

Created:
5 years, 3 months ago by nweiz
Modified:
5 years, 3 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/pub.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Make pub lish validation gitignore-aware. Pub won't upload gitignored files, so its validation shouldn't consider them to exist either. See #1321 R=rnystrom@google.com Committed: https://github.com/dart-lang/pub/commit/9987a9d7e1fcf26665ce56b06c49bf40dbb0ddc3

Patch Set 1 #

Patch Set 2 : fix #

Patch Set 3 : analysis hints #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+111 lines, -14 lines) Patch
M lib/src/package.dart View 2 chunks +5 lines, -6 lines 0 comments Download
M lib/src/validator.dart View 2 chunks +2 lines, -0 lines 0 comments Download
M lib/src/validator/executable.dart View 1 chunk +2 lines, -1 line 2 comments Download
M lib/src/validator/license.dart View 1 chunk +1 line, -1 line 0 comments Download
A lib/src/validator/pubspec.dart View 1 2 1 chunk +29 lines, -0 lines 0 comments Download
M test/descriptor/git.dart View 1 chunk +1 line, -1 line 0 comments Download
M test/validator/executable_test.dart View 1 chunk +19 lines, -0 lines 0 comments Download
M test/validator/license_test.dart View 1 chunk +13 lines, -5 lines 0 comments Download
A test/validator/pubspec_test.dart View 1 chunk +29 lines, -0 lines 0 comments Download
M test/validator/utf8_readme_test.dart View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
nweiz
5 years, 3 months ago (2015-08-26 22:44:48 UTC) #1
Bob Nystrom
One suggestion but LGTM! https://codereview.chromium.org/1310253007/diff/40001/lib/src/validator/executable.dart File lib/src/validator/executable.dart (right): https://codereview.chromium.org/1310253007/diff/40001/lib/src/validator/executable.dart#newcode24 lib/src/validator/executable.dart:24: beneath: "bin", recursive: false, useGitIgnore: ...
5 years, 3 months ago (2015-08-26 23:21:44 UTC) #2
nweiz
https://codereview.chromium.org/1310253007/diff/40001/lib/src/validator/executable.dart File lib/src/validator/executable.dart (right): https://codereview.chromium.org/1310253007/diff/40001/lib/src/validator/executable.dart#newcode24 lib/src/validator/executable.dart:24: beneath: "bin", recursive: false, useGitIgnore: true) On 2015/08/26 23:21:44, ...
5 years, 3 months ago (2015-08-27 19:07:56 UTC) #3
nweiz
5 years, 3 months ago (2015-08-27 19:08:11 UTC) #4
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
9987a9d7e1fcf26665ce56b06c49bf40dbb0ddc3 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698