Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(578)

Unified Diff: test/validator/license_test.dart

Issue 1310253007: Make pub lish validation gitignore-aware. (Closed) Base URL: git@github.com:dart-lang/pub.git@master
Patch Set: analysis hints Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: test/validator/license_test.dart
diff --git a/test/validator/license_test.dart b/test/validator/license_test.dart
index 814f3b4c292e8cecb1920dc6c5b34ca687212d9f..05da9a037d5b3be2921f73d195d2337cb2784750 100644
--- a/test/validator/license_test.dart
+++ b/test/validator/license_test.dart
@@ -40,10 +40,18 @@ main() {
});
});
- integration('should consider a package invalid if it has no LICENSE file',
- () {
- d.validPackage.create();
- schedule(() => deleteEntry(path.join(sandboxDir, appPath, 'LICENSE')));
- expectValidationError(license);
+ group('should consider a package invalid if it', () {
+ integration('has no LICENSE file', () {
+ d.validPackage.create();
+ schedule(() => deleteEntry(path.join(sandboxDir, appPath, 'LICENSE')));
+ expectValidationError(license);
+ });
+
+ integration('has a .gitignored LICENSE file', () {
+ var repo = d.git(appPath, [d.file(".gitignore", "LICENSE")]);
+ d.validPackage.create();
+ repo.create();
+ expectValidationError(license);
+ });
});
}

Powered by Google App Engine
This is Rietveld 408576698