Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(392)

Unified Diff: test/validator/executable_test.dart

Issue 1310253007: Make pub lish validation gitignore-aware. (Closed) Base URL: git@github.com:dart-lang/pub.git@master
Patch Set: analysis hints Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: test/validator/executable_test.dart
diff --git a/test/validator/executable_test.dart b/test/validator/executable_test.dart
index 12610855e98c26a549c3ccbc44248712d22b9968..fbd6c1ec4aeedf8d1ea2f26bc0d3939208cc094b 100644
--- a/test/validator/executable_test.dart
+++ b/test/validator/executable_test.dart
@@ -51,5 +51,24 @@ main() {
]).create();
expectValidationWarning(executable);
});
+
+ integration('has .gitignored one or more listed executables', () {
+ d.git(appPath, [
+ d.pubspec({
+ "name": "test_pkg",
+ "version": "1.0.0",
+ "executables": {
+ "one": "one_script",
+ "two": null
+ }
+ }),
+ d.dir("bin", [
+ d.file("one_script.dart", "main() => print('ok');"),
+ d.file("two.dart", "main() => print('ok');")
+ ]),
+ d.file(".gitignore", "bin")
+ ]).create();
+ expectValidationWarning(executable);
+ });
});
}

Powered by Google App Engine
This is Rietveld 408576698