Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(717)

Unified Diff: test/validator/utf8_readme_test.dart

Issue 1310253007: Make pub lish validation gitignore-aware. (Closed) Base URL: git@github.com:dart-lang/pub.git@master
Patch Set: analysis hints Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« lib/src/validator/executable.dart ('K') | « test/validator/pubspec_test.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/validator/utf8_readme_test.dart
diff --git a/test/validator/utf8_readme_test.dart b/test/validator/utf8_readme_test.dart
index e930790f5e031a295936d956e48f91f4f6f7e05f..7aad43ed05c270afaa453989fab1938219dd3737 100644
--- a/test/validator/utf8_readme_test.dart
+++ b/test/validator/utf8_readme_test.dart
@@ -27,6 +27,16 @@ main() {
]).create();
expectNoValidationError(utf8Readme);
});
+
+ integration('has a .gitignored README with invalid utf-8', () {
+ var repo = d.git(appPath, [
+ d.binaryFile("README", [192]),
+ d.file(".gitignore", "README")
+ ]);
+ d.validPackage.create();
+ repo.create();
+ expectNoValidationError(utf8Readme);
+ });
});
integration('should consider a package invalid if it has a README with '
« lib/src/validator/executable.dart ('K') | « test/validator/pubspec_test.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698