Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1065)

Unified Diff: lib/src/validator/executable.dart

Issue 1310253007: Make pub lish validation gitignore-aware. (Closed) Base URL: git@github.com:dart-lang/pub.git@master
Patch Set: analysis hints Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/src/validator.dart ('k') | lib/src/validator/license.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/src/validator/executable.dart
diff --git a/lib/src/validator/executable.dart b/lib/src/validator/executable.dart
index 939b443470e8180dd1474c85853537d5359edb0a..ee52ce8799907870f26f797c65ea1c56cafc72f0 100644
--- a/lib/src/validator/executable.dart
+++ b/lib/src/validator/executable.dart
@@ -20,7 +20,8 @@ class ExecutableValidator extends Validator {
Future validate() async {
// TODO(rnystrom): This can print false positives since a script may be
// produced by a transformer. Do something better.
- var binFiles = entrypoint.root.listFiles(beneath: "bin", recursive: false)
+ var binFiles = entrypoint.root.listFiles(
+ beneath: "bin", recursive: false, useGitIgnore: true)
Bob Nystrom 2015/08/26 23:21:44 Since this is copied in a few validators, how abou
nweiz 2015/08/27 19:07:56 I think adding a wrapper function that just change
.map((path) => entrypoint.root.relative(path))
.toList();
« no previous file with comments | « lib/src/validator.dart ('k') | lib/src/validator/license.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698