Issue 1295693002: Add ObjectPool tag for external labels. Use LoadExternalLabel for native calls...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1295693002: Add ObjectPool tag for external labels. Use LoadExternalLabel for native calls... (Closed)

Created:
5 years, 4 months ago by rmacnak

Modified:
5 years, 4 months ago

Reviewers:
Florian Schneider

CC:
reviews_dartlang.org, vm-dev_dartlang.org, regis

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Add ObjectPool tag for external labels. Use LoadExternalLabel for native calls and the predefined symbols table. R=fschneider@google.com Committed: https://github.com/dart-lang/sdk/commit/294c6a47a4103c90e7065851d5c7f213b6b5e87f

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+34 lines, -23 lines)			Patch
M	runtime/observatory/lib/src/elements/objectpool_view.dart	View	1	2 chunks	+5 lines, -5 lines	0 comments	Download
M	runtime/observatory/lib/src/elements/objectpool_view.html	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/assembler.cc	View	1 2	2 chunks	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/intermediate_language_arm.cc	View		2 chunks	+5 lines, -3 lines	0 comments	Download
M	runtime/vm/intermediate_language_arm64.cc	View		2 chunks	+5 lines, -3 lines	0 comments	Download
M	runtime/vm/intermediate_language_mips.cc	View		2 chunks	+4 lines, -3 lines	0 comments	Download
M	runtime/vm/intermediate_language_x64.cc	View		2 chunks	+5 lines, -4 lines	0 comments	Download
M	runtime/vm/object.h	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/object.cc	View	1	2 chunks	+6 lines, -2 lines	0 comments	Download

Total messages: 4 (1 generated)

rmacnak

5 years, 4 months ago (2015-08-14 17:10:39 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 (id:40001) manually as
294c6a47a4103c90e7065851d5c7f213b6b5e87f (presubmit successful).