Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Unified Diff: runtime/observatory/lib/src/elements/objectpool_view.dart

Issue 1295693002: Add ObjectPool tag for external labels. Use LoadExternalLabel for native calls... (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/observatory/lib/src/elements/objectpool_view.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/observatory/lib/src/elements/objectpool_view.dart
diff --git a/runtime/observatory/lib/src/elements/objectpool_view.dart b/runtime/observatory/lib/src/elements/objectpool_view.dart
index 9bc5a4e666184e119af9b94034223dbf0382075c..5b320a1c97b5b90425d7ef644937a274af2956d8 100644
--- a/runtime/observatory/lib/src/elements/objectpool_view.dart
+++ b/runtime/observatory/lib/src/elements/objectpool_view.dart
@@ -19,13 +19,13 @@ class ObjectPoolViewElement extends ObservatoryElement {
bool isServiceObject(o) => o is ServiceObject;
void poolChanged(oldValue) {
- annotateRawEntries();
+ annotateExternalLabels();
}
- Future annotateRawEntries() {
+ Future annotateExternalLabels() {
var tasks = pool.entries.map((entry) {
- if (entry is int) {
- var addr = entry.toRadixString(16);
+ if (entry is String) {
+ var addr = entry.substring(2);
return pool.isolate.getObjectByAddress(addr).then((result) {
return result is ServiceObject ? result : null;
});
@@ -38,6 +38,6 @@ class ObjectPoolViewElement extends ObservatoryElement {
}
Future refresh() {
- return pool.reload().then((_) => annotateRawEntries());
+ return pool.reload().then((_) => annotateExternalLabels());
}
}
« no previous file with comments | « no previous file | runtime/observatory/lib/src/elements/objectpool_view.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698