Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(731)

Unified Diff: runtime/vm/intermediate_language_mips.cc

Issue 1295693002: Add ObjectPool tag for external labels. Use LoadExternalLabel for native calls... (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/intermediate_language_arm64.cc ('k') | runtime/vm/intermediate_language_x64.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/intermediate_language_mips.cc
diff --git a/runtime/vm/intermediate_language_mips.cc b/runtime/vm/intermediate_language_mips.cc
index df32f00e18be6c6d2058d5863eaeb28e29605a32..2e21a8a8b60c89611fc609617c42cfb01b2e7e41 100644
--- a/runtime/vm/intermediate_language_mips.cc
+++ b/runtime/vm/intermediate_language_mips.cc
@@ -1012,7 +1012,8 @@ void NativeCallInstr::EmitNativeCode(FlowGraphCompiler* compiler) {
}
#endif
}
- __ LoadImmediate(T5, entry);
+ ExternalLabel label(entry);
+ __ LoadExternalLabel(T5, &label, kNotPatchable);
__ LoadImmediate(A1, argc_tag);
compiler->GenerateCall(token_pos(),
*stub_entry,
@@ -1040,8 +1041,8 @@ void StringFromCharCodeInstr::EmitNativeCode(FlowGraphCompiler* compiler) {
__ Comment("StringFromCharCodeInstr");
- __ LoadImmediate(result,
- reinterpret_cast<uword>(Symbols::PredefinedAddress()));
+ ExternalLabel label(reinterpret_cast<uword>(Symbols::PredefinedAddress()));
+ __ LoadExternalLabel(result, &label, kNotPatchable);
__ AddImmediate(result, Symbols::kNullCharCodeSymbolOffset * kWordSize);
__ sll(TMP, char_code, 1); // Char code is a smi.
__ addu(TMP, TMP, result);
« no previous file with comments | « runtime/vm/intermediate_language_arm64.cc ('k') | runtime/vm/intermediate_language_x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698