Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Unified Diff: runtime/vm/intermediate_language_x64.cc

Issue 1295693002: Add ObjectPool tag for external labels. Use LoadExternalLabel for native calls... (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/intermediate_language_mips.cc ('k') | runtime/vm/object.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/intermediate_language_x64.cc
diff --git a/runtime/vm/intermediate_language_x64.cc b/runtime/vm/intermediate_language_x64.cc
index 84afa6fe150a94d6e6dd77e19fa61203df4d6e92..6c150fd3e0ed53271e33626cf6c4b08dd4f85aff 100644
--- a/runtime/vm/intermediate_language_x64.cc
+++ b/runtime/vm/intermediate_language_x64.cc
@@ -781,8 +781,8 @@ void NativeCallInstr::EmitNativeCode(FlowGraphCompiler* compiler) {
} else {
__ leaq(RAX, Address(RBP, kFirstLocalSlotFromFp * kWordSize));
}
- __ LoadImmediate(
- RBX, Immediate(reinterpret_cast<uword>(native_c_function())));
+ ExternalLabel label(reinterpret_cast<uword>(native_c_function()));
+ __ LoadExternalLabel(RBX, &label, kNotPatchable);
__ LoadImmediate(R10, Immediate(argc_tag));
const StubEntry& stub_entry = (is_bootstrap_native() || is_leaf_call) ?
*StubCode::CallBootstrapCFunction_entry() :
@@ -822,8 +822,9 @@ void StringFromCharCodeInstr::EmitNativeCode(FlowGraphCompiler* compiler) {
ASSERT(compiler->is_optimizing());
Register char_code = locs()->in(0).reg();
Register result = locs()->out(0).reg();
- __ LoadImmediate(result,
- Immediate(reinterpret_cast<uword>(Symbols::PredefinedAddress())));
+
+ ExternalLabel label(reinterpret_cast<uword>(Symbols::PredefinedAddress()));
+ __ LoadExternalLabel(result, &label, kNotPatchable);
__ movq(result, Address(result,
char_code,
TIMES_HALF_WORD_SIZE, // Char code is a smi.
« no previous file with comments | « runtime/vm/intermediate_language_mips.cc ('k') | runtime/vm/object.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698