Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1370)

Unified Diff: runtime/vm/intermediate_language_arm64.cc

Issue 1295693002: Add ObjectPool tag for external labels. Use LoadExternalLabel for native calls... (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/intermediate_language_arm.cc ('k') | runtime/vm/intermediate_language_mips.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/intermediate_language_arm64.cc
diff --git a/runtime/vm/intermediate_language_arm64.cc b/runtime/vm/intermediate_language_arm64.cc
index 9587767ac1070d8973a83f837954bd40efd9113a..10bd177a37b59158c01821b7f86ae6a299d61a32 100644
--- a/runtime/vm/intermediate_language_arm64.cc
+++ b/runtime/vm/intermediate_language_arm64.cc
@@ -814,7 +814,8 @@ void NativeCallInstr::EmitNativeCode(FlowGraphCompiler* compiler) {
}
#endif
}
- __ LoadImmediate(R5, entry);
+ ExternalLabel label(entry);
+ __ LoadExternalLabel(R5, &label);
__ LoadImmediate(R1, argc_tag);
compiler->GenerateCall(token_pos(),
*stub_entry,
@@ -839,8 +840,9 @@ void StringFromCharCodeInstr::EmitNativeCode(FlowGraphCompiler* compiler) {
ASSERT(compiler->is_optimizing());
const Register char_code = locs()->in(0).reg();
const Register result = locs()->out(0).reg();
- __ LoadImmediate(
- result, reinterpret_cast<uword>(Symbols::PredefinedAddress()));
+
+ ExternalLabel label(reinterpret_cast<uword>(Symbols::PredefinedAddress()));
+ __ LoadExternalLabel(result, &label);
__ AddImmediate(
result, result, Symbols::kNullCharCodeSymbolOffset * kWordSize);
__ SmiUntag(TMP, char_code); // Untag to use scaled adress mode.
« no previous file with comments | « runtime/vm/intermediate_language_arm.cc ('k') | runtime/vm/intermediate_language_mips.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698