Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 12294028: Fix warnings spotted by dart. (Closed)

Created:
7 years, 10 months ago by ahe
Modified:
7 years, 10 months ago
Reviewers:
karlklose
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix warnings spotted by dartc. Committed: https://code.google.com/p/dart/source/detail?r=18680

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+202 lines, -202 lines) Patch
M dart/sdk/lib/_internal/compiler/implementation/code_buffer.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M dart/sdk/lib/_internal/compiler/implementation/dart_backend/backend.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M dart/sdk/lib/_internal/compiler/implementation/dart_backend/renamer.dart View 4 chunks +12 lines, -12 lines 0 comments Download
M dart/sdk/lib/_internal/compiler/implementation/dart_types.dart View 3 chunks +20 lines, -20 lines 0 comments Download
M dart/sdk/lib/_internal/compiler/implementation/deferred_load.dart View 4 chunks +7 lines, -4 lines 0 comments Download
M dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart View 2 chunks +8 lines, -8 lines 0 comments Download
M dart/sdk/lib/_internal/compiler/implementation/js_backend/namer.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M dart/sdk/lib/_internal/compiler/implementation/js_backend/runtime_types.dart View 1 chunk +7 lines, -7 lines 0 comments Download
M dart/sdk/lib/_internal/compiler/implementation/scanner/keyword.dart View 2 chunks +7 lines, -7 lines 0 comments Download
M dart/sdk/lib/_internal/compiler/implementation/scanner/string_scanner.dart View 1 chunk +1 line, -1 line 0 comments Download
M dart/sdk/lib/_internal/compiler/implementation/scanner/token.dart View 1 chunk +1 line, -1 line 0 comments Download
M dart/sdk/lib/_internal/compiler/implementation/source_file.dart View 2 chunks +6 lines, -6 lines 0 comments Download
M dart/sdk/lib/_internal/compiler/implementation/source_map_builder.dart View 5 chunks +18 lines, -18 lines 0 comments Download
M dart/sdk/lib/_internal/compiler/implementation/ssa/nodes.dart View 1 chunk +5 lines, -5 lines 0 comments Download
M dart/sdk/lib/_internal/compiler/implementation/ssa/tracer.dart View 7 chunks +21 lines, -21 lines 0 comments Download
M dart/sdk/lib/_internal/compiler/implementation/tree/dartstring.dart View 1 chunk +1 line, -1 line 0 comments Download
M dart/sdk/lib/_internal/compiler/implementation/tree/prettyprint.dart View 5 chunks +11 lines, -11 lines 0 comments Download
M dart/sdk/lib/_internal/compiler/implementation/tree/unparser.dart View 26 chunks +58 lines, -58 lines 0 comments Download
M dart/sdk/lib/_internal/compiler/implementation/universe/universe.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M dart/sdk/lib/_internal/compiler/implementation/util/link_implementation.dart View 1 chunk +5 lines, -5 lines 0 comments Download
M dart/sdk/lib/_internal/compiler/implementation/util/uri_extras.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M dart/tests/utils/utils.status View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
ahe
7 years, 10 months ago (2013-02-19 12:30:06 UTC) #1
karlklose
7 years, 10 months ago (2013-02-19 12:41:43 UTC) #2
LGTM!

Powered by Google App Engine
This is Rietveld 408576698